* Cogito: split Makefile targets of Cogito/git
@ 2005-06-11 19:50 Kay Sievers
2005-06-11 20:06 ` Sven Verdoolaege
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Kay Sievers @ 2005-06-11 19:50 UTC (permalink / raw)
To: Petr Baudis; +Cc: git
[-- Attachment #1: Type: text/plain, Size: 168 bytes --]
This splits the targets of Cogito/git to be able to call it
independently. This way we can easily make Cogito a separate
package, which just requires git.
Thanks,
Kay
[-- Attachment #2: cogito-Makefile-split-install.patch --]
[-- Type: text/plain, Size: 1043 bytes --]
diff --git a/Makefile b/Makefile
--- a/Makefile
+++ b/Makefile
@@ -112,9 +112,10 @@ endif
CFLAGS += '-DSHA1_HEADER=$(SHA1_HEADER)'
-
-all: $(PROG) $(GEN_SCRIPT)
-
+.PHONY: all it cogito
+all: git cogito
+git: $(PROG)
+cogito: $(GEN_SCRIPT)
test-delta: test-delta.c diff-delta.o patch-delta.o
$(CC) $(CFLAGS) -o $@ $^
@@ -169,9 +170,16 @@ test: all
sedlibdir=$(shell echo $(libdir) | sed 's/\//\\\//g')
-install: $(PROG) $(SCRIPTS) $(SCRIPT) $(LIB_SCRIPT) $(GEN_SCRIPT)
+.PHONY: install install-git install-cogito
+install: install-git install-cogito
+
+install-git: $(PROG) $(SCRIPTS)
+ $(INSTALL) -m755 -d $(DESTDIR)$(bindir)
+ $(INSTALL) $(PROG) $(SCRIPTS) $(DESTDIR)$(bindir)
+
+install-cogito: $(SCRIPT) $(LIB_SCRIPT) $(GEN_SCRIPT)
$(INSTALL) -m755 -d $(DESTDIR)$(bindir)
- $(INSTALL) $(PROG) $(SCRIPTS) $(SCRIPT) $(GEN_SCRIPT) $(DESTDIR)$(bindir)
+ $(INSTALL) $(SCRIPT) $(GEN_SCRIPT) $(DESTDIR)$(bindir)
$(INSTALL) -m755 -d $(DESTDIR)$(libdir)
$(INSTALL) $(LIB_SCRIPT) $(DESTDIR)$(libdir)
cd $(DESTDIR)$(bindir); \
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: Cogito: split Makefile targets of Cogito/git
2005-06-11 19:50 Cogito: split Makefile targets of Cogito/git Kay Sievers
@ 2005-06-11 20:06 ` Sven Verdoolaege
2005-06-11 20:19 ` Kay Sievers
2005-06-11 22:09 ` Junio C Hamano
2 siblings, 0 replies; 5+ messages in thread
From: Sven Verdoolaege @ 2005-06-11 20:06 UTC (permalink / raw)
To: Kay Sievers; +Cc: Petr Baudis, git
On Sat, Jun 11, 2005 at 09:50:33PM +0200, Kay Sievers wrote:
> +.PHONY: all it cogito
I suppose this should be
+.PHONY: all git cogito
skimo
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: Cogito: split Makefile targets of Cogito/git
2005-06-11 19:50 Cogito: split Makefile targets of Cogito/git Kay Sievers
2005-06-11 20:06 ` Sven Verdoolaege
@ 2005-06-11 20:19 ` Kay Sievers
2005-06-11 21:11 ` Petr Baudis
2005-06-11 22:09 ` Junio C Hamano
2 siblings, 1 reply; 5+ messages in thread
From: Kay Sievers @ 2005-06-11 20:19 UTC (permalink / raw)
To: Petr Baudis; +Cc: git
[-- Attachment #1: Type: text/plain, Size: 345 bytes --]
On Sat, Jun 11, 2005 at 09:50:33PM +0200, Kay Sievers wrote:
> This splits the targets of Cogito/git to be able to call it
> independently. This way we can easily make Cogito a separate
> package, which just requires git.
> +.PHONY: all it cogito
"all it cogito" sounds funny, but is obviously wrong. :)
New patch attached.
Thanks Dave!
Kay
[-- Attachment #2: cogito-Makefile-split-install.patch --]
[-- Type: text/plain, Size: 1044 bytes --]
diff --git a/Makefile b/Makefile
--- a/Makefile
+++ b/Makefile
@@ -112,9 +112,10 @@ endif
CFLAGS += '-DSHA1_HEADER=$(SHA1_HEADER)'
-
-all: $(PROG) $(GEN_SCRIPT)
-
+.PHONY: all git cogito
+all: git cogito
+git: $(PROG)
+cogito: $(GEN_SCRIPT)
test-delta: test-delta.c diff-delta.o patch-delta.o
$(CC) $(CFLAGS) -o $@ $^
@@ -169,9 +170,16 @@ test: all
sedlibdir=$(shell echo $(libdir) | sed 's/\//\\\//g')
-install: $(PROG) $(SCRIPTS) $(SCRIPT) $(LIB_SCRIPT) $(GEN_SCRIPT)
+.PHONY: install install-git install-cogito
+install: install-git install-cogito
+
+install-git: $(PROG) $(SCRIPTS)
+ $(INSTALL) -m755 -d $(DESTDIR)$(bindir)
+ $(INSTALL) $(PROG) $(SCRIPTS) $(DESTDIR)$(bindir)
+
+install-cogito: $(SCRIPT) $(LIB_SCRIPT) $(GEN_SCRIPT)
$(INSTALL) -m755 -d $(DESTDIR)$(bindir)
- $(INSTALL) $(PROG) $(SCRIPTS) $(SCRIPT) $(GEN_SCRIPT) $(DESTDIR)$(bindir)
+ $(INSTALL) $(SCRIPT) $(GEN_SCRIPT) $(DESTDIR)$(bindir)
$(INSTALL) -m755 -d $(DESTDIR)$(libdir)
$(INSTALL) $(LIB_SCRIPT) $(DESTDIR)$(libdir)
cd $(DESTDIR)$(bindir); \
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: Cogito: split Makefile targets of Cogito/git
2005-06-11 20:19 ` Kay Sievers
@ 2005-06-11 21:11 ` Petr Baudis
0 siblings, 0 replies; 5+ messages in thread
From: Petr Baudis @ 2005-06-11 21:11 UTC (permalink / raw)
To: Kay Sievers; +Cc: git
Dear diary, on Sat, Jun 11, 2005 at 10:19:33PM CEST, I got a letter
where Kay Sievers <kay.sievers@vrfy.org> told me that...
> On Sat, Jun 11, 2005 at 09:50:33PM +0200, Kay Sievers wrote:
> > This splits the targets of Cogito/git to be able to call it
> > independently. This way we can easily make Cogito a separate
> > package, which just requires git.
>
> > +.PHONY: all it cogito
>
> "all it cogito" sounds funny, but is obviously wrong. :)
> New patch attached.
Could you please sign off the patch?
Thanks,
--
Petr "Pasky" Baudis
Stuff: http://pasky.or.cz/
<Espy> be careful, some twit might quote you out of context..
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: Cogito: split Makefile targets of Cogito/git
2005-06-11 19:50 Cogito: split Makefile targets of Cogito/git Kay Sievers
2005-06-11 20:06 ` Sven Verdoolaege
2005-06-11 20:19 ` Kay Sievers
@ 2005-06-11 22:09 ` Junio C Hamano
2 siblings, 0 replies; 5+ messages in thread
From: Junio C Hamano @ 2005-06-11 22:09 UTC (permalink / raw)
To: Kay Sievers; +Cc: git
>>>>> "KS" == Kay Sievers <kay.sievers@vrfy.org> writes:
KS> -
KS> -all: $(PROG) $(GEN_SCRIPT)
KS> -
KS> +.PHONY: all it cogito
KS> +all: git cogito
KS> +git: $(PROG)
KS> +cogito: $(GEN_SCRIPT)
(Tongue in cheek) How about this instead ;^)
-
-all: $(PROG) $(GEN_SCRIPT)
-
+.PHONY: all git coo
+all: git coo
+git: $(PROG)
+coo: $(GEN_SCRIPT)
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2005-06-11 22:05 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2005-06-11 19:50 Cogito: split Makefile targets of Cogito/git Kay Sievers
2005-06-11 20:06 ` Sven Verdoolaege
2005-06-11 20:19 ` Kay Sievers
2005-06-11 21:11 ` Petr Baudis
2005-06-11 22:09 ` Junio C Hamano
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).