hgweb and gitweb: Commit times displayed incorrectly

hgweb and gitweb: Commit times displayed incorrectly

[Radoslaw Szkodzinski]

Who is wrong there, especially with hours count?
Here it's 17:43 +0200

hgweb:
*16 hours ago: * 	*[PATCH] Typo in fbdev sysfs support, virtual_size *
changeset 30069:  	e888fb306d22e08c14c3aedac3ea32f8a918c0c0
<http://www.kernel.org/hg/?cmd=changeset;node=e888fb306d22e08c14c3aedac3ea32f8a918c0c0>

parent:  	67be48281441be602419b1ceb0bd419b3be4b84b
<http://www.kernel.org/hg/?cmd=changeset;node=67be48281441be602419b1ceb0bd419b3be4b84b>

author:  	Jon Smirl <jonsmirl@gmail.com <mailto:jonsmirl@gmail.com>>
date:  	Mon Jun 13 22:52:36 2005
files
<http://www.kernel.org/hg/?cmd=manifest;manifest=c775357b0cce7d4f6835a5e1755a7c00c8a6516c;path=/>: 
	drivers/video/fbsysfs.c
<http://www.kernel.org/hg/?cmd=filediff;node=e888fb306d22e08c14c3aedac3ea32f8a918c0c0;file=drivers/video/fbsysfs.c>



gitweb:
/11 hours ago/ 	/Jon Smirl/ 	*[PATCH] Typo in fbdev sysfs support,
virtual_size*
<http://www.kernel.org/git/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=e2c16499515aa044676a14b97a1b8a35f879152a>



author 	Jon Smirl <jonsmirl@gmail.com <mailto:jonsmirl@gmail.com>>

	Mon, 13 Jun 2005 22:52:36 +0000 (15:52 -0700)
committer 	Linus Torvalds <torvalds@ppc970.osdl.org
<mailto:torvalds@ppc970.osdl.org>>

	Tue, 14 Jun 2005 03:58:58 +0000 (20:58 -0700)
commit 	e2c16499515aa044676a14b97a1b8a35f879152a


My clone:
commit e2c16499515aa044676a14b97a1b8a35f879152a
tree 87addb997369837e8cdad63c212876d161691ad2
parent 6df3cecbb95345981718b38d357c50bc3425420a
author Jon Smirl <jonsmirl@gmail.com> Mon, 13 Jun 2005 15:52:36 -0700
committer Linus Torvalds <torvalds@ppc970.osdl.org> Mon, 13 Jun 2005
20:58:58 -0700

    [PATCH] Typo in fbdev sysfs support, virtual_size

Re: hgweb and gitweb: Commit times displayed incorrectly

[Thomas Arendsen Hein]

* Radoslaw Szkodzinski <astralstorm@gorzow.mm.pl> [20050614 17:45]:
> Who is wrong there, especially with hours count?
> Here it's 17:43 +0200
> 
> hgweb:
> *16 hours ago: *

http://www.kernel.org/hg/?cmd=changelog;rev=30069

> gitweb:
> /11 hours ago/

http://www.kernel.org/git/?p=linux/kernel/git/torvalds/linux-2.6.git;a=log;h=e2c16499515aa044676a14b97a1b8a35f879152a

> My clone:
> author Jon Smirl <jonsmirl@gmail.com> Mon, 13 Jun 2005 15:52:36 -0700
> committer Linus Torvalds <torvalds@ppc970.osdl.org> Mon, 13 Jun 2005 20:58:58 -0700

Both are correct.

hgweb uses the timestamp of the "author" line, gitweb uses the
timestamp of the "commiter" line. Mercurial (hg) doesn't distinguish
author and commiter, therefore it uses the earlier time.

Regards,
Thomas Arendsen Hein

-- 
Email: thomas@intevation.de
http://intevation.de/~thomas/

Re: hgweb and gitweb: Commit times displayed incorrectly

[Matt Mackall]

On Tue, Jun 14, 2005 at 06:25:41PM +0200, Thomas Arendsen Hein wrote:
> * Radoslaw Szkodzinski <astralstorm@gorzow.mm.pl> [20050614 17:45]:
> > Who is wrong there, especially with hours count?
> > Here it's 17:43 +0200
> > 
> > hgweb:
> > *16 hours ago: *
> 
> http://www.kernel.org/hg/?cmd=changelog;rev=30069
> 
> > gitweb:
> > /11 hours ago/
> 
> http://www.kernel.org/git/?p=linux/kernel/git/torvalds/linux-2.6.git;a=log;h=e2c16499515aa044676a14b97a1b8a35f879152a
> 
> > My clone:
> > author Jon Smirl <jonsmirl@gmail.com> Mon, 13 Jun 2005 15:52:36 -0700
> > committer Linus Torvalds <torvalds@ppc970.osdl.org> Mon, 13 Jun 2005 20:58:58 -0700
> 
> Both are correct.
> 
> hgweb uses the timestamp of the "author" line, gitweb uses the
> timestamp of the "commiter" line. Mercurial (hg) doesn't distinguish
> author and commiter, therefore it uses the earlier time.

I may change this. One of the goals here is to have enough information
to generate git-compatible exports. Possibly through an extended
version of hgweb (hgitweb?).

So I'm eventually going to preserve both fields. The question is how.
Do we want separate author and committer fields in Mercurial?

-- 
Mathematics is the supreme nostalgia of our time.