Git development
 help / color / mirror / Atom feed
From: Jon Seymour <jon.seymour@gmail.com>
To: git@vger.kernel.org
Cc: torvalds@osdl.org, jon.seymour@gmail.com
Subject: [PATCH 1/3] Demonstrate broken t6001 test case function
Date: Thu, 30 Jun 2005 12:41:55 +1000	[thread overview]
Message-ID: <20050630024155.32511.qmail@blackcubes.dyndns.org> (raw)


Junio discovered a problem where an actual test case break was hidden because pipelines
are not handled properly by the test infrastructure in t6001.

This patch fixes the broken infrastructure (and demonstrates the break explicitly).

A subsequent patch in this series will fix the test case so that it doesn't fail.

Signed-off-by: Jon Seymour <jon.seymour@gmail.com>
---

This patch set:
   * demonstrates and fixes some broken test infrastructure
   * fixes a broken test case that was previously hidden by the broken infrastructure
   * simplifies the test case to remove an unnecessary sort.

Although all patches in the set touch the same file, I have broken it into
three smaller patches to highlight the 3 different changes.

This patch set patches assumes that this series has been applied:

[PATCH 1/2] Test case that demonstrates problem with --merge-order ^ processing
[PATCH 2/2] Fix for git-rev-list --merge-order B ^A (A,B share common base) [rev 2]

 t/t6001-rev-list-merge-order.sh |    5 ++---
 1 files changed, 2 insertions(+), 3 deletions(-)

0b0041e1fdb1b25757b0c861a0832c54b922440b
diff --git a/t/t6001-rev-list-merge-order.sh b/t/t6001-rev-list-merge-order.sh
--- a/t/t6001-rev-list-merge-order.sh
+++ b/t/t6001-rev-list-merge-order.sh
@@ -85,13 +85,12 @@ check_output()
 {
 	_name=$1
 	shift 1
-	if "$@" | entag > $_name.actual
+	if eval "$*" | entag > $_name.actual
 	then
 		diff $_name.expected $_name.actual
 	else
 		return 1;
 	fi
-	
 }
 
 # Turn a reasonable test description into a reasonable test name.
@@ -114,7 +113,7 @@ test_output_expect_success()
         [ $# -eq 2 ] || error "usage: test_output_expect_success description test <<EOF ... EOF"
         _name=$(echo $_description | name_from_description)
 	cat > $_name.expected
-	test_expect_success "$_description" "check_output $_name $_test" 
+	test_expect_success "$_description" "check_output $_name \"$_test\"" 
 }
 
 # --- end of stuff to move ---
------------

                 reply	other threads:[~2005-06-30  2:35 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20050630024155.32511.qmail@blackcubes.dyndns.org \
    --to=jon.seymour@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=torvalds@osdl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox