git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Petr Baudis <pasky@suse.cz>
To: Wolfgang Denk <wd@denx.de>
Cc: git@vger.kernel.org
Subject: Re: Should cg-mkpatch output be usable with cg-patch?
Date: Mon, 25 Jul 2005 00:48:30 +0200	[thread overview]
Message-ID: <20050724224830.GG7601@pasky.ji.cz> (raw)
In-Reply-To: <20050724175018.3D721352B73@atlas.denx.de>

Dear diary, on Sun, Jul 24, 2005 at 07:50:18PM CEST, I got a letter
where Wolfgang Denk <wd@denx.de> told me that...
> In message <20050722210352.GG11916@pasky.ji.cz> you wrote:
> >
> > > I wander what I should do with "cg-mkpatch" generated output;  I  had
> > > the  impression that this should be usable with "cg-patch", but these
> > > are incompatible with each other.
> > 
> > They certainly aren't.
> 
> Is this a problem with the current implementation, or intentional?

Implementation. Should be fixed now, after rewriting part of it. ;-)

> > The message is surely confusing, but appeared to be rather corner-casy
> > and after I imagined the required complexity of filtering this, I
> > decided to spend my time on something more useful for the time being. :)
> 
> I don't think this is a corner case. I think it is  pretty  important
> to be able to promote permissiong changes.

Of course. By the corner case I meant "the external patch tool invoked
by cg-patch emits bogus error in case of patch containing only mode
changes and nothing else". I wasn't aware that the changes wouldn't
apply at all - actually, I was when I was writing the code, but
completely forgot about it later.

Thanks,

-- 
				Petr "Pasky" Baudis
Stuff: http://pasky.or.cz/
If you want the holes in your knowledge showing up try teaching
someone.  -- Alan Cox

      reply	other threads:[~2005-07-24 22:48 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-07-20 23:49 Should cg-mkpatch output be usable with cg-patch? Wolfgang Denk
2005-07-21  3:57 ` Junio C Hamano
2005-07-22 21:02   ` Petr Baudis
2005-07-22 21:03 ` Petr Baudis
2005-07-24 17:50   ` Wolfgang Denk
2005-07-24 22:48     ` Petr Baudis [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20050724224830.GG7601@pasky.ji.cz \
    --to=pasky@suse.cz \
    --cc=git@vger.kernel.org \
    --cc=wd@denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).