Can't build RPM's from current cogito tree

Can't build RPM's from current cogito tree

[Wolfgang Denk]

Building of RPM's from the current cogito tree fails:

-> rpmbuild -ba cogito.spec 
...
make -C tools install
make[1]: Entering directory `/usr/local/BUILD/cogito-0.12.1/tools'
gcc -g -O2 -Wall -o git-mailsplit mailsplit.c
gcc -g -O2 -Wall -o git-mailinfo mailinfo.c
install -m755 -d /usr/bin
install: cannot change permissions of `/usr/bin': Operation not permitted
make[1]: *** [install] Error 1
make[1]: Leaving directory `/usr/local/BUILD/cogito-0.12.1/tools'
make: *** [install-tools] Error 2
error: Bad exit status from /var/tmp/rpm-tmp.6363 (%install)


This fixes it:

diff --git a/Makefile b/Makefile
--- a/Makefile
+++ b/Makefile
@@ -245,10 +245,10 @@ install-cogito: $(SCRIPT) $(LIB_SCRIPT) 
 	done
 
 install-tools:
-	$(MAKE) -C tools install
+	$(MAKE) -C tools dest=$(DESTDIR) install
 
 install-doc:
-	$(MAKE) -C Documentation install
+	$(MAKE) -C Documentation dest=$(DESTDIR) install
 
 uninstall:
 	cd $(DESTDIR)$(bindir) && rm -f $(PROG) $(SCRIPTS) $(SCRIPT) $(GEN_SCRIPT)


Best regards,

Wolfgang Denk

-- 
Software Engineering:  Embedded and Realtime Systems,  Embedded Linux
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd@denx.de
Every program has at least one bug and can be shortened by  at  least
one  instruction  --  from  which,  by induction, one can deduce that
every program can be reduced to one instruction which doesn't work.

Re: Can't build RPM's from current cogito tree

[Petr Baudis]

Dear diary, on Thu, Aug 04, 2005 at 10:47:19PM CEST, I got a letter
where Wolfgang Denk <wd@denx.de> told me that...
> Building of RPM's from the current cogito tree fails:
> 
> -> rpmbuild -ba cogito.spec 
> ...
> make -C tools install
> make[1]: Entering directory `/usr/local/BUILD/cogito-0.12.1/tools'
> gcc -g -O2 -Wall -o git-mailsplit mailsplit.c
> gcc -g -O2 -Wall -o git-mailinfo mailinfo.c
> install -m755 -d /usr/bin
> install: cannot change permissions of `/usr/bin': Operation not permitted
> make[1]: *** [install] Error 1
> make[1]: Leaving directory `/usr/local/BUILD/cogito-0.12.1/tools'
> make: *** [install-tools] Error 2
> error: Bad exit status from /var/tmp/rpm-tmp.6363 (%install)
> 
> 
> This fixes it:
> 
> diff --git a/Makefile b/Makefile
> --- a/Makefile
> +++ b/Makefile
> @@ -245,10 +245,10 @@ install-cogito: $(SCRIPT) $(LIB_SCRIPT) 
>  	done
>  
>  install-tools:
> -	$(MAKE) -C tools install
> +	$(MAKE) -C tools dest=$(DESTDIR) install
>  
>  install-doc:
> -	$(MAKE) -C Documentation install
> +	$(MAKE) -C Documentation dest=$(DESTDIR) install
>  
>  uninstall:
>  	cd $(DESTDIR)$(bindir) && rm -f $(PROG) $(SCRIPTS) $(SCRIPT) $(GEN_SCRIPT)

Thanks, I fixed it the other way around, changing Documentation/Makefile
to use $DESTDIR. :-)

-- 
				Petr "Pasky" Baudis
Stuff: http://pasky.or.cz/
If you want the holes in your knowledge showing up try teaching
someone.  -- Alan Cox