Git development
 help / color / mirror / Atom feed
From: Petr Baudis <pasky@suse.cz>
To: Junio C Hamano <junkio@cox.net>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] Clean generated files a bit more.
Date: Fri, 12 Aug 2005 13:40:53 +0200	[thread overview]
Message-ID: <20050812114053.GB29893@pasky.ji.cz> (raw)
In-Reply-To: <7v8xz75w6p.fsf@assigned-by-dhcp.cox.net>

Dear diary, on Fri, Aug 12, 2005 at 11:41:34AM CEST, I got a letter
where Junio C Hamano <junkio@cox.net> told me that...
> Also attempt to build a source package for debian.
> ---
> 
>  Makefile |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> b263f24ce4f12dd39cfcd922c56a32292c6232c9
> diff --git a/Makefile b/Makefile
> --- a/Makefile
> +++ b/Makefile
> @@ -238,14 +238,14 @@ rpm: dist
>  deb: dist
>  	rm -rf $(GIT_TARNAME)
>  	tar zxf $(GIT_TARNAME).tar.gz
> +	dpkg-source -b $(GIT_TARNAME)
>  	cd $(GIT_TARNAME) && fakeroot debian/rules binary
>  
>  ### Cleaning rules
>  
>  clean:
>  	rm -f *.o mozilla-sha1/*.o ppc/*.o $(PROG) $(LIB_FILE)
> -	rm -f $(GIT_TARNAME).tar.gz git-core.spec
> -	rm -f git-core_$(GIT_VERSION)-*.deb git-tk_$(GIT_VERSION)-*.deb
> +	rm -f git-core.spec *.deb *.dsc *.tar.gz 


This makes me a bit nervous - why are you making the rules more general?
make clean removing random tarballs of mine happenning to dwell in that
directory is fearsome.

-- 
				Petr "Pasky" Baudis
Stuff: http://pasky.or.cz/
If you want the holes in your knowledge showing up try teaching
someone.  -- Alan Cox

  reply	other threads:[~2005-08-12 11:41 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-08-12  9:41 [PATCH] Clean generated files a bit more Junio C Hamano
2005-08-12 11:40 ` Petr Baudis [this message]
2005-08-12 13:55   ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20050812114053.GB29893@pasky.ji.cz \
    --to=pasky@suse.cz \
    --cc=git@vger.kernel.org \
    --cc=junkio@cox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox