Git development
 help / color / mirror / Atom feed
From: Josef Weidendorfer <Josef.Weidendorfer@gmx.de>
To: git@vger.kernel.org
Subject: Re: [PATCH] Add --signoff and --verify option to git commit.
Date: Mon, 15 Aug 2005 23:21:16 +0200	[thread overview]
Message-ID: <200508152321.17075.Josef.Weidendorfer@gmx.de> (raw)
In-Reply-To: <7vzmrmp5kw.fsf@assigned-by-dhcp.cox.net>

On Saturday 13 August 2005 11:08, Junio C Hamano wrote:
> Also add --verify to make sure the lines you introduced are
> clean, which is more useful in commit but not very much in
> format-patch as it was originally implemented, because finding
> botches at format-patch time is too late.

I think that verification of/commenting on commits at/before commit time is a 
perfect place for another hook script (or collection of verification 
scripts).

People probably want to check a new commit on identation/coding style on a 
per-project manner. The hook also should be able to give warnings/hints by 
adding text to the commit message (e.g. "please do not use 'fgetc'" / 
"doublecheck quoting in system()", ...) without rejecting the commit as a 
whole. It could even be allowed to edit the code before commit.

These verification scripts should be used per default, and git-commit should 
have an option to force bypassing verification.

If I get some time, I can come up with a patch.

Josef

  reply	other threads:[~2005-08-15 21:22 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-08-13  9:08 [PATCH] Add --signoff and --verify option to git commit Junio C Hamano
2005-08-15 21:21 ` Josef Weidendorfer [this message]
2005-08-16  0:13   ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200508152321.17075.Josef.Weidendorfer@gmx.de \
    --to=josef.weidendorfer@gmx.de \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox