git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Kay Sievers <kay.sievers@vrfy.org>
To: Linus Torvalds <torvalds@osdl.org>
Cc: Git Mailing List <git@vger.kernel.org>
Subject: Re: hmm, can't we give the "root" a parent?
Date: Mon, 12 Sep 2005 23:00:06 +0200	[thread overview]
Message-ID: <20050912210006.GA32211@vrfy.org> (raw)
In-Reply-To: <Pine.LNX.4.58.0509121316030.3266@g5.osdl.org>

On Mon, Sep 12, 2005 at 01:21:13PM -0700, Linus Torvalds wrote:
> On Mon, 12 Sep 2005, Kay Sievers wrote:
> >
> > And good to know about that, need to fix the "parent" link in gitweb to
> > respect grafts.
> 
> Note that the simplest way to do this is to try to use "git-rev-list" as 
> much as possible. The "--parents" flag makes the output have the parents 
> (automatically _including_ any grafts) on the line that contains the 
> commit ID.
> 
> That's especially true of any tools that use git-rev-list anyway for other
> reasons. Eg "gitk" could parse the parent stuff this way, and didn't need
> to know about the info/grafts file at all. I suspect the same should be
> true of gitweb.

Everthing that walk from one commit to another, uses git-rev-list, sure.
But in the commit view, and the commitdiff the "parent" link and the parent
that is passed to diff is read from the commit itself.

> (So instead of trying to parse the parent info from the header of the 
> commit, just do "git-rev-list --pretty --parents" and parse that).

I need only one parent:
  git-rev-list --parents --max-count=1 <id>

Hmm, it's one more exec, but I don't need to look at the grafts file or
whatever will make it into git the next time I will look at it. :)

Thanks,
Kay

  reply	other threads:[~2005-09-12 21:00 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-09-12 18:11 hmm, can't we give the "root" a parent? Kay Sievers
2005-09-12 18:26 ` Linus Torvalds
2005-09-12 19:59   ` Kay Sievers
2005-09-12 20:21     ` Linus Torvalds
2005-09-12 21:00       ` Kay Sievers [this message]
2005-09-12 21:42         ` Linus Torvalds
2005-09-12 22:50           ` Kay Sievers
2005-09-12 23:06             ` Linus Torvalds
2005-09-12 23:09             ` Linus Torvalds
2005-09-12 23:51               ` Kay Sievers
2005-09-12 18:27 ` A Large Angry SCM
2005-09-16 15:39 ` gitweb search in multi-headed tree Tony Luck
2005-09-17  1:22   ` Kay Sievers

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20050912210006.GA32211@vrfy.org \
    --to=kay.sievers@vrfy.org \
    --cc=git@vger.kernel.org \
    --cc=torvalds@osdl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).