Git development
 help / color / mirror / Atom feed
From: Petr Baudis <pasky@suse.cz>
To: Junio C Hamano <junkio@cox.net>
Cc: "David K?.A?Negedal" <davidk@lysator.liu.se>, git@vger.kernel.org
Subject: Re: [PATCH] Added an option to cvsimport to specify email domain
Date: Wed, 14 Sep 2005 21:34:57 +0200	[thread overview]
Message-ID: <20050914193457.GE2936@pasky.or.cz> (raw)
In-Reply-To: <7vhdcw661g.fsf@assigned-by-dhcp.cox.net>

Dear diary, on Wed, Sep 07, 2005 at 09:18:03PM CEST, I got a letter
where Junio C Hamano <junkio@cox.net> told me that...
> David K?.A?Negedal <davidk@lysator.liu.se> writes:
> 
> > The authorship info in commits created by git-cvsimport-script
> > only contains the username of the CVS committer.  This patch
> > adds a flag -e <domain> to git-cvsimport-script that makes it
> > possible to specify an email domain that is added to all email
> > addresses in the commit "author" and "committer" fields.
> >
> > ---
> > I have stopped using cvsimport, because cvsps seems to produce bad
> > output on the repository I'm using it with, but I had already prepared
> > this patch.
> 
> Hmph.  One reason the original implementation did not do this is
> because Linus and other people wanted to have a repeatability,
> so making this an optional thing is good, but if we go this
> route, I think if it would be nicer to have a --author-map
> option that lets you feed a list of:
> 
>     <author> ==> "A U Thor <author@author.dom>"
> 
> mappings, instead of a single -e, which essentially does not add
> much information to the result.
> 
> I take that your oob comment indicates that you do not have much
> incentive/inclination to further hack on this, so I am not
> asking you to do the above even if you find my suggestion
> worthwhile.

Various tools use CVSROOT/users to map usernames to realname <email>.
I actually wanted to send a patch, looked at the cvsimport script and
got totally scared away (at least for now)... ;-)

-- 
				Petr "Pasky" Baudis
Stuff: http://pasky.or.cz/
If you want the holes in your knowledge showing up try teaching
someone.  -- Alan Cox

  reply	other threads:[~2005-09-14 19:35 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-09-07  8:00 [PATCH] Added an option to cvsimport to specify email domain David Kågedal
2005-09-07 19:18 ` Junio C Hamano
2005-09-14 19:34   ` Petr Baudis [this message]
2005-09-27  4:34     ` Alexey Nezhdanov
2005-09-27 12:54       ` David Mansfield
2005-09-30  8:19         ` Alexey Nezhdanov
2005-09-30  8:48           ` Junio C Hamano
2005-09-30 10:22             ` Alexey Nezhdanov
2005-09-30 13:54           ` David Mansfield
2005-09-29 10:26       ` Alexey Nezhdanov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20050914193457.GE2936@pasky.or.cz \
    --to=pasky@suse.cz \
    --cc=davidk@lysator.liu.se \
    --cc=git@vger.kernel.org \
    --cc=junkio@cox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox