git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Anton Blanchard <anton@samba.org>
To: git@vger.kernel.org
Subject: [PATCH] bisect succeeds but has non zero exit code
Date: Sat, 17 Sep 2005 14:32:39 +1000	[thread overview]
Message-ID: <20050917043239.GG14962@krispykreme> (raw)


Hi,

I was writing some scripts to automate a bisection search and noticed
I could get a non zero exit code when the command succeeded:

# git-bisect start
# echo $?
0

# git-bisect good ef4cbee0b0d0f791bb593f99b702410f3c0efce6
# echo $?
1

# git bisect bad 6d36ba629e0ef47a03d3703ee1d38143c25532a8
Bisecting: 13 revisions left to test after this
[1619cca2921f6927f4240e03f413d4165c7002fc] Partially revert "Fix time
going twice as fast problem on ATI Xpress chipsets"
# echo $?
0

It looks like bisect_next_check returns false and we return a non zero
exit code. The following patch forces a good exit code in that case.

Signed-off-by: Anton Blanchard <anton@samba.org>
---

--- git-bisect.sh.orig	2005-09-15 17:37:08.000000000 +1000
+++ git-bisect.sh	2005-09-17 14:24:30.000000000 +1000
@@ -111,6 +111,7 @@
 
 bisect_auto_next() {
 	bisect_next_check && bisect_next
+	true
 }
 
 bisect_next() {

                 reply	other threads:[~2005-09-17  4:35 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20050917043239.GG14962@krispykreme \
    --to=anton@samba.org \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).