From: Kay Sievers <kay.sievers@vrfy.org>
To: Nico -telmich- Schottelius <nico-linux-git@schottelius.org>
Cc: git@vger.kernel.org, Christian Gierke <ch@gierke.de>
Subject: Re: first impressions to git
Date: Sun, 18 Sep 2005 23:39:13 +0200 [thread overview]
Message-ID: <20050918213913.GC13315@vrfy.org> (raw)
In-Reply-To: <20050918211855.GA1463@schottelius.org>
On Sun, Sep 18, 2005 at 11:18:56PM +0200, Nico -telmich- Schottelius wrote:
> First of all, thanks for that many very good explaining answers.
> Than I tried gitweb.cgi, which seems to have a small bug validating input:
>
> if ($input =~ m/(^|\/)(|\.|\.\.)($|\/)/) {
>
> This also matches a cLinux/cinit.git as far as I can see.
> I use '(^|\/)(\.\.|\.)($|\/)' currently, but I am not totally sure, whether
> this is correct.
It fails cause you have a "non canonical" file name with a trailing
slash.
> You can see the original version on
> http://linux.schottelius.org/cgi-bin/gitweb-orig.cgi
> and my modified version on
> http://linux.schottelius.org/cgi-bin/gitweb.cgi
>
> But perhaps the logic in gitweb.cgi should be changed:
Just remove the trailing slash from your project name and everything
should be fine.
Kay
next prev parent reply other threads:[~2005-09-18 21:39 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-09-18 11:12 first impressions to git Nico -telmich- Schottelius
2005-09-18 14:54 ` Petr Baudis
[not found] ` <94fc236b050918073351075bb4@mail.gmail.com>
2005-09-18 21:18 ` Nico -telmich- Schottelius
2005-09-18 21:39 ` Kay Sievers [this message]
2005-09-18 22:09 ` Junio C Hamano
2005-09-18 22:11 ` Petr Baudis
2005-09-18 22:23 ` Junio C Hamano
2005-09-18 22:29 ` Linus Torvalds
2005-09-18 16:56 ` Daniel Barkalow
2005-09-18 17:31 ` Junio C Hamano
2005-09-19 19:14 ` Sven Verdoolaege
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050918213913.GC13315@vrfy.org \
--to=kay.sievers@vrfy.org \
--cc=ch@gierke.de \
--cc=git@vger.kernel.org \
--cc=nico-linux-git@schottelius.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).