git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Petr Baudis <pasky@suse.cz>
To: "H. Peter Anvin" <hpa@zytor.com>
Cc: Dmitry Torokhov <dtor_core@ameritech.net>, git@vger.kernel.org
Subject: Re: Garbage in .git directories???
Date: Tue, 20 Sep 2005 01:40:30 +0200	[thread overview]
Message-ID: <20050919234030.GI18320@pasky.or.cz> (raw)
In-Reply-To: <432F46BE.5000406@zytor.com>

Dear diary, on Tue, Sep 20, 2005 at 01:16:14AM CEST, I got a letter
where "H. Peter Anvin" <hpa@zytor.com> told me that...
> Petr Baudis wrote:
> >>
> >>FWIW, using cg-clone (using git-core 0.99.6 and cogito 0.14.1) I keep 
> >>finding a directory in .git which consists of a single DEL character 
> >>(\177).
> >
> >Does cg-init produce it too? It really seems that this has to be a bug
> >in git-init-db. If that is the case, could you try temporarily renaming
> >the templates directory?
> 
> cg-init does produce it, too.  I'm not sure what you mean with 
> temporarily renaming the templates directory?

Preventing git-init-db to copy its stuff into your .git/ - I think the
bug is likely somewhere there. Actually, this can be prevented by
passing an argument to git-init-db:

	git-init-db --template=somethingnonexisting

Another idea - try this patch:

diff --git a/init-db.c b/init-db.c
--- a/init-db.c
+++ b/init-db.c
@@ -154,6 +154,7 @@ static void copy_templates(const char *g
 	}
 
 	memcpy(path, git_dir, len);
+	path[len] = 0;
 	copy_templates_1(path, len,
 			 template_path, template_len,
 			 dir);

-- 
				Petr "Pasky" Baudis
Stuff: http://pasky.or.cz/
VI has two modes: the one in which it beeps and the one in which
it doesn't.

  reply	other threads:[~2005-09-19 23:40 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-09-18  2:41 Garbage in .git directories??? Dmitry Torokhov
2005-09-18 17:10 ` Linus Torvalds
2005-09-18 17:54   ` Dmitry Torokhov
2005-09-19  4:33     ` Dmitry Torokhov
2005-09-19  5:21       ` Junio C Hamano
2005-09-19 14:51       ` Linus Torvalds
2005-09-19 15:00         ` Dmitry Torokhov
2005-09-20  0:09         ` Dmitry Torokhov
2005-09-20  0:45           ` Linus Torvalds
2005-09-20  3:37             ` Dmitry Torokhov
2005-09-19 19:10 ` H. Peter Anvin
2005-09-19 19:44   ` Petr Baudis
2005-09-19 23:16     ` H. Peter Anvin
2005-09-19 23:40       ` Petr Baudis [this message]
2005-09-19 23:58         ` H. Peter Anvin
2005-09-20  0:07           ` [PATCH] Fix git-init-db creating crap directories Petr Baudis
2005-09-20  0:09             ` H. Peter Anvin
2005-09-20  0:19               ` [PATCH] Fix git-init-db creating crap directories (zeroth try) Petr Baudis
2005-09-20  0:42                 ` H. Peter Anvin
2005-09-20  1:51                   ` Petr Baudis
2005-09-20  2:04                     ` Junio C Hamano
2005-09-20  3:27                     ` H. Peter Anvin
2005-09-19 21:58   ` Garbage in .git directories??? Horst von Brand

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20050919234030.GI18320@pasky.or.cz \
    --to=pasky@suse.cz \
    --cc=dtor_core@ameritech.net \
    --cc=git@vger.kernel.org \
    --cc=hpa@zytor.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).