From: Petr Baudis <pasky@suse.cz>
To: Martin Langhoff <martin@catalyst.net.nz>,
Martin Langhoff <martin.langhoff@gmail.com>
Cc: git@vger.kernel.org, kevin@catalyst.net.nz
Subject: Re: [PATCH] cg-diff fixed to work with BSD xargs
Date: Tue, 20 Sep 2005 21:36:06 +0200 [thread overview]
Message-ID: <20050920193606.GD28621@pasky.or.cz> (raw)
In-Reply-To: <46a038f905091921154a70123f@mail.gmail.com> <11253960093915-git-send-email-martin@catalyst.net.nz>
Dear diary, on Tue, Aug 30, 2005 at 12:00:10PM CEST, I got a letter
where Martin Langhoff <martin@catalyst.net.nz> told me that...
> Calls to cg-diff without filename parameters were dependent on GNU xargs
> traits. BSD xargs is hardcoded to do --no-run-if-empty -- so if the filter
> is effectively empty we avoid calling xargs.
>
> Signed-off-by: Martin Langhoff <martin@catalyst.net.nz>
Thanks, I've applied it and also fixed the second git-diff-tree usage.
Dear diary, on Tue, Sep 20, 2005 at 06:15:28AM CEST, I got a letter
where Martin Langhoff <martin.langhoff@gmail.com> told me that...
> We still have a bug in cg-diff when using the BSD xargs. I posted a
> fix, and Junio posted an alternative approach. The original patches
> are here http://marc.theaimsgroup.com/?l=git&m=112541165904627&w=2
Looks like I've overlooked it in my fast Cogito patch scan. There are
still parts of mailing list history in late August and early September
that I didn't read.
--
Petr "Pasky" Baudis
Stuff: http://pasky.or.cz/
VI has two modes: the one in which it beeps and the one in which
it doesn't.
next prev parent reply other threads:[~2005-09-20 19:36 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-09-20 4:15 cg-diff still broken on some BSDs Martin Langhoff
2005-08-30 10:00 ` [PATCH] cg-diff fixed to work with BSD xargs Martin Langhoff
2005-08-30 14:20 ` Junio C Hamano
2005-09-20 19:39 ` Petr Baudis
2005-09-20 19:36 ` Petr Baudis [this message]
2005-09-21 7:33 ` Matthias Urlichs
2005-09-21 8:15 ` Petr Baudis
2005-09-21 10:06 ` Matthias Urlichs
2005-09-21 10:11 ` Petr Baudis
2005-09-21 10:54 ` Matthias Urlichs
2005-09-21 10:56 ` Martin Langhoff
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050920193606.GD28621@pasky.or.cz \
--to=pasky@suse.cz \
--cc=git@vger.kernel.org \
--cc=kevin@catalyst.net.nz \
--cc=martin.langhoff@gmail.com \
--cc=martin@catalyst.net.nz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).