From: Petr Baudis <pasky@suse.cz>
To: Junio C Hamano <junkio@cox.net>
Cc: Martin Langhoff <martin@catalyst.net.nz>, git@vger.kernel.org
Subject: Re: [PATCH] cg-diff fixed to work with BSD xargs
Date: Tue, 20 Sep 2005 21:39:56 +0200 [thread overview]
Message-ID: <20050920193956.GE28621@pasky.or.cz> (raw)
In-Reply-To: <7v7je3ld53.fsf@assigned-by-dhcp.cox.net>
Dear diary, on Tue, Aug 30, 2005 at 04:20:40PM CEST, I got a letter
where Junio C Hamano <junkio@cox.net> told me that...
> But the code you are fixing looks to me like it is already
> somewhat obsolete, even if it is still working. The munging of
> user-given paths into $filter temporary file was necessary only
> because older git-diff-* family did not work from anywhere but
> the top-level directory; they do, thanks to Linus' enhancements,
> these days.
>
> I think it is time to start updating Cogito to take advantage of
> the modern core. I do not do Porcelains, but here is my stab at
> it.
Thanks for the patch - it'd be actually very nice to get rid of the
complexity. But more than that, I want to be consistent - so do all the
GIT core commands work in subdirectories by now, or only a subset of
them? I'd hate to have half of the scripts stay in the subdirectory
and half use the Cogito's old relpath logic, so it's either everything
or anything from my POV.
Thanks,
--
Petr "Pasky" Baudis
Stuff: http://pasky.or.cz/
VI has two modes: the one in which it beeps and the one in which
it doesn't.
next prev parent reply other threads:[~2005-09-20 19:40 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-09-20 4:15 cg-diff still broken on some BSDs Martin Langhoff
2005-08-30 10:00 ` [PATCH] cg-diff fixed to work with BSD xargs Martin Langhoff
2005-08-30 14:20 ` Junio C Hamano
2005-09-20 19:39 ` Petr Baudis [this message]
2005-09-20 19:36 ` Petr Baudis
2005-09-21 7:33 ` Matthias Urlichs
2005-09-21 8:15 ` Petr Baudis
2005-09-21 10:06 ` Matthias Urlichs
2005-09-21 10:11 ` Petr Baudis
2005-09-21 10:54 ` Matthias Urlichs
2005-09-21 10:56 ` Martin Langhoff
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050920193956.GE28621@pasky.or.cz \
--to=pasky@suse.cz \
--cc=git@vger.kernel.org \
--cc=junkio@cox.net \
--cc=martin@catalyst.net.nz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).