From: Petr Baudis <pasky@suse.cz>
To: Pavel Roskin <proski@gnu.org>
Cc: git <git@vger.kernel.org>
Subject: Re: [PATCH 6/8] cogito: Don't ever assume object type in cg-object-id
Date: Wed, 21 Sep 2005 12:00:40 +0200 [thread overview]
Message-ID: <20050921100040.GE24902@pasky.or.cz> (raw)
In-Reply-To: <1127183120.31115.34.camel@dv>
Dear diary, on Tue, Sep 20, 2005 at 04:25:20AM CEST, I got a letter
where Pavel Roskin <proski@gnu.org> told me that...
> Don't ever assume object type in cg-object-id.
>
> If type is unknown in normalize_id(), make it empty so it's checked
> later. Check parent ID that it's a commit.
Why? In most of the cases, you have one pointless fork() more, and we
"assume" only if it was in a parent line, and if that's not a commit,
you've got a *serious* problem with your database. fsck should yell you
to death, and I don't think you could even normally commit such a
commit, so this should never happen. There's no point in wasting time
trying to handle seriously messed up database.
--
Petr "Pasky" Baudis
Stuff: http://pasky.or.cz/
VI has two modes: the one in which it beeps and the one in which
it doesn't.
next prev parent reply other threads:[~2005-09-21 10:00 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-09-20 2:25 [PATCH 6/8] cogito: Don't ever assume object type in cg-object-id Pavel Roskin
2005-09-21 10:00 ` Petr Baudis [this message]
2005-09-22 3:27 ` Pavel Roskin
2005-09-22 9:46 ` Petr Baudis
2005-09-22 9:52 ` Petr Baudis
2005-09-22 15:37 ` Pavel Roskin
2005-09-22 15:50 ` Petr Baudis
2005-09-22 16:55 ` Pavel Roskin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050921100040.GE24902@pasky.or.cz \
--to=pasky@suse.cz \
--cc=git@vger.kernel.org \
--cc=proski@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).