git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Petr Baudis <pasky@suse.cz>
To: Matthias Urlichs <smurf@smurf.noris.de>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] cg-diff fixed to work with BSD xargs
Date: Wed, 21 Sep 2005 12:11:13 +0200	[thread overview]
Message-ID: <20050921101113.GF24902@pasky.or.cz> (raw)
In-Reply-To: <20050921100631.GQ14206@kiste.smurf.noris.de>

Dear diary, on Wed, Sep 21, 2005 at 12:06:31PM CEST, I got a letter
where Matthias Urlichs <smurf@smurf.noris.de> told me that...
> Hi,

Hi,

> Petr Baudis:
> > 
> > $filter is a file name. -s tests whether the file of that name exists
> > and is non-empty.
> > 
> True -- but it's still a bug.
> 
> If the name itself is empty (or has spaces), you get wrong results.

but the name is never empty. It can contain spaces, and this should be
fixed, but we have a lot of places to fix in Cogito if it is to work
right with $TMPDIR containing spaces (what a weird idea).

-- 
				Petr "Pasky" Baudis
Stuff: http://pasky.or.cz/
VI has two modes: the one in which it beeps and the one in which
it doesn't.

  reply	other threads:[~2005-09-21 10:11 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-09-20  4:15 cg-diff still broken on some BSDs Martin Langhoff
2005-08-30 10:00 ` [PATCH] cg-diff fixed to work with BSD xargs Martin Langhoff
2005-08-30 14:20   ` Junio C Hamano
2005-09-20 19:39     ` Petr Baudis
2005-09-20 19:36   ` Petr Baudis
2005-09-21  7:33   ` Matthias Urlichs
2005-09-21  8:15     ` Petr Baudis
2005-09-21 10:06       ` Matthias Urlichs
2005-09-21 10:11         ` Petr Baudis [this message]
2005-09-21 10:54           ` Matthias Urlichs
2005-09-21 10:56     ` Martin Langhoff

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20050921101113.GF24902@pasky.or.cz \
    --to=pasky@suse.cz \
    --cc=git@vger.kernel.org \
    --cc=smurf@smurf.noris.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).