From: Nick Hengeveld <nickh@reactrix.com>
To: Junio C Hamano <junkio@cox.net>
Cc: Daniel Barkalow <barkalow@iabervon.org>, git@vger.kernel.org
Subject: Re: [PATCH] Add support for parallel HTTP transfers
Date: Fri, 7 Oct 2005 10:22:06 -0700 [thread overview]
Message-ID: <20051007172206.GK15593@reactrix.com> (raw)
In-Reply-To: <7v8xx55kia.fsf@assigned-by-dhcp.cox.net>
On Fri, Oct 07, 2005 at 10:01:33AM -0700, Junio C Hamano wrote:
> The check was added in 029f6de377c7e0484f5c4cf070934599580f1784
> because back then calling fetch() on an object that we already
> had had a funny interaction with what http-fetch.c did. I
> suspect that Nick's curl-multi changes made it unnecessary, but
> you should double check for other transports.
I think the only downside to leaving that check in place is that when
pull() finishes there may be completed requests left behind in the
queue, possibly with unreported transfer errors. Would it make sense
to just release any requests left in the queue after pull(), and report
if any of them had transfer errors?
--
For a successful technology, reality must take precedence over public
relations, for nature cannot be fooled.
next prev parent reply other threads:[~2005-10-07 17:22 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-10-05 21:44 [PATCH] Add support for parallel HTTP transfers Nick Hengeveld
2005-10-06 20:07 ` Daniel Barkalow
2005-10-07 0:00 ` Nick Hengeveld
2005-10-07 0:51 ` Junio C Hamano
2005-10-07 4:56 ` Nick Hengeveld
2005-10-07 5:15 ` Junio C Hamano
2005-10-07 16:23 ` Daniel Barkalow
2005-10-07 17:01 ` Junio C Hamano
2005-10-07 17:22 ` Nick Hengeveld [this message]
2005-10-07 18:08 ` Junio C Hamano
2005-10-07 22:39 ` Daniel Barkalow
2005-10-10 16:48 ` Jon Loeliger
2005-10-07 17:41 ` Daniel Barkalow
2005-10-07 18:08 ` Junio C Hamano
-- strict thread matches above, loose matches on Subject: below --
2005-10-06 18:54 Nick Hengeveld
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20051007172206.GK15593@reactrix.com \
--to=nickh@reactrix.com \
--cc=barkalow@iabervon.org \
--cc=git@vger.kernel.org \
--cc=junkio@cox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).