Git development
 help / color / mirror / Atom feed
From: Petr Baudis <pasky@suse.cz>
To: Martin Langhoff <martin@catalyst.net.nz>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] cg-tag - add support for longer commit messages
Date: Wed, 12 Oct 2005 01:39:40 +0200	[thread overview]
Message-ID: <20051011233940.GJ30889@pasky.or.cz> (raw)
In-Reply-To: <11289987493327-git-send-email-martin@catalyst.net.nz>

Dear diary, on Tue, Oct 11, 2005 at 04:45:49AM CEST, I got a letter
where Martin Langhoff <martin@catalyst.net.nz> told me that...
> Added an -m switch that points to a filename which contains a (potentially
> long) tag message.
> 
> Bugs: Could alternatively be implemented via STDIN.

Hmm. Well, the '-d' option is silly and that's really what should read
as '-m', to keep it the same as cg-commit. Actually, I'd like to have it
as similar as possible, so it would be ideal to have cg-tag do something
like

	if got_argument '-e'; then
		if tty -s; then
			throw_together_some_CG:_stuff
			$EDITOR
			parse_the_CG:_stuff
		else
			cat >>logmsg
		fi
	fi

to keep it symmetric to cg-commit (except that it won't require the
message if you don't bother to pass it anything). Well, I guess the CG:
stuff parsing is lower priority (and would require some factoring out of
the common code from cg-commit), so I'll do the simple part soon
(today or on Thursday) if noone does it first. *hint* *hint* ;-)

-- 
				Petr "Pasky" Baudis
Stuff: http://pasky.or.cz/
VI has two modes: the one in which it beeps and the one in which
it doesn't.

      parent reply	other threads:[~2005-10-11 23:39 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-10-11  2:45 [PATCH] cg-tag - add support for longer commit messages Martin Langhoff
2005-10-11 14:57 ` Linus Torvalds
2005-10-11 23:39 ` Petr Baudis [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20051011233940.GJ30889@pasky.or.cz \
    --to=pasky@suse.cz \
    --cc=git@vger.kernel.org \
    --cc=martin@catalyst.net.nz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox