From: Petr Baudis <pasky@suse.cz>
To: "H. Peter Anvin" <hpa@zytor.com>
Cc: Git Mailing List <git@vger.kernel.org>
Subject: Re: [PATCH] git-daemon: timeout, eliminate double DWIM
Date: Thu, 20 Oct 2005 02:28:45 +0200 [thread overview]
Message-ID: <20051020002845.GT30889@pasky.or.cz> (raw)
In-Reply-To: <4356966A.8010401@zytor.com>
Dear diary, on Wed, Oct 19, 2005 at 08:54:34PM CEST, I got a letter
where "H. Peter Anvin" <hpa@zytor.com> told me that...
> diff --git a/daemon.c b/daemon.c
> --- a/daemon.c
> +++ b/daemon.c
> @@ -13,7 +13,9 @@
> static int log_syslog;
> static int verbose;
>
> -static const char daemon_usage[] = "git-daemon [--verbose] [--syslog] [--inetd | --port=n] [--export-all] [directory...]";
> +static const char daemon_usage[] =
> +"git-daemon [--verbose] [--syslog] [--inetd | --port=n] [--export-all]\n"
> +" [--timeout=n] [--init-timeout=n] [directory...]";
>
> /* List of acceptable pathname prefixes */
> static char **ok_paths = NULL;
You didn't update Documentation/git-daemon.txt.
> diff --git a/upload-pack.c b/upload-pack.c
> --- a/upload-pack.c
> +++ b/upload-pack.c
> @@ -4,13 +4,19 @@
> #include "tag.h"
> #include "object.h"
>
> -static const char upload_pack_usage[] = "git-upload-pack <dir>";
> +static const char upload_pack_usage[] = "git-upload-pack [--strict] [--timeout=nn] <dir>";
Ditto.
After being confronted with incomplete documentation again just minutes
ago (will send patch soon), I think I'm going to start to be annoying
and watch patches for this issue specifically. ;-)
--
Petr "Pasky" Baudis
Stuff: http://pasky.or.cz/
VI has two modes: the one in which it beeps and the one in which
it doesn't.
next prev parent reply other threads:[~2005-10-20 0:28 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-10-19 18:54 [PATCH] git-daemon: timeout, eliminate double DWIM H. Peter Anvin
2005-10-20 0:28 ` Petr Baudis [this message]
2005-10-20 1:18 ` Junio C Hamano
2005-10-20 1:26 ` Petr Baudis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20051020002845.GT30889@pasky.or.cz \
--to=pasky@suse.cz \
--cc=git@vger.kernel.org \
--cc=hpa@zytor.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).