From: Petr Baudis <pasky@suse.cz>
To: Junio C Hamano <junkio@cox.net>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] Fix empty line processing in git-shortlog.perl
Date: Sun, 6 Nov 2005 23:44:22 +0100 [thread overview]
Message-ID: <20051106224422.GQ1431@pasky.or.cz> (raw)
In-Reply-To: <20051106224218.22797.97260.stgit@machine.or.cz>
Dear diary, on Sun, Nov 06, 2005 at 11:42:18PM CET, I got a letter
where Petr Baudis <pasky@suse.cz> told me that...
> diff --git a/git-shortlog.perl b/git-shortlog.perl
> index 0b14f83..7283159 100755
> --- a/git-shortlog.perl
> +++ b/git-shortlog.perl
> @@ -94,7 +94,7 @@ sub changelog_input {
>
> # skip to non-blank line
> elsif ($pstate == 3) {
> - next unless /^\s*?(.*)/;
> + next unless /^\s*?(\S.*)$/;
>
> # skip lines that are obviously not
> # a 1-line cset description
>
Whoops, the ? was not part of the original regexp and is obviously
useless. Well, I don't think it really matters, so it is up to you...
--
Petr "Pasky" Baudis
Stuff: http://pasky.or.cz/
VI has two modes: the one in which it beeps and the one in which
it doesn't.
next prev parent reply other threads:[~2005-11-06 22:44 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-11-06 22:42 [PATCH] Fix empty line processing in git-shortlog.perl Petr Baudis
2005-11-06 22:44 ` Petr Baudis [this message]
2005-11-07 2:56 ` Junio C Hamano
2005-11-07 20:46 ` Petr Baudis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20051106224422.GQ1431@pasky.or.cz \
--to=pasky@suse.cz \
--cc=git@vger.kernel.org \
--cc=junkio@cox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox