From: exon@op5.se (Andreas Ericsson)
To: git@vger.kernel.org
Subject: [PATCH] git-daemon: --inetd implies --syslog
Date: Mon, 14 Nov 2005 17:41:01 +0100 (CET) [thread overview]
Message-ID: <20051114164101.58A495BF92@nox.op5.se> (raw)
Otherwise nothing is logged anywhere, which is a Bad Thing.
Signed-off-by: Andreas Ericsson <ae@op5.se>
---
Documentation/git-daemon.txt | 2 +-
daemon.c | 6 +++---
2 files changed, 4 insertions(+), 4 deletions(-)
applies-to: 963d67921d6f65c08d51a8c93811f03274c34703
9fac415ad7ec34c21b20b3c349872304869505df
diff --git a/Documentation/git-daemon.txt b/Documentation/git-daemon.txt
index 67c5f22..3783858 100644
--- a/Documentation/git-daemon.txt
+++ b/Documentation/git-daemon.txt
@@ -35,7 +35,7 @@ OPTIONS
do not have the 'git-daemon-export-ok' file.
--inetd::
- Have the server run as an inetd service.
+ Have the server run as an inetd service. Implies --syslog.
--port::
Listen on an alternative port.
diff --git a/daemon.c b/daemon.c
index c3f8641..50a3396 100644
--- a/daemon.c
+++ b/daemon.c
@@ -627,9 +627,9 @@ int main(int argc, char **argv)
}
if (inetd_mode) {
- fclose(stderr); //FIXME: workaround
+ log_syslog = 1;
return execute();
- } else {
- return serve(port);
}
+
+ return serve(port);
}
---
0.99.9.GIT
next reply other threads:[~2005-11-14 16:41 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-11-14 16:41 Andreas Ericsson [this message]
2005-11-14 20:54 ` [PATCH] git-daemon: --inetd implies --syslog Junio C Hamano
2005-11-14 21:23 ` Andreas Ericsson
2005-11-14 22:01 ` Junio C Hamano
2005-11-14 23:59 ` H. Peter Anvin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20051114164101.58A495BF92@nox.op5.se \
--to=exon@op5.se \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).