From: Chuck Lever <cel@netapp.com>
To: git@vger.kernel.org
Subject: [PATCH 1/4] Better error message when renaming patches to same name
Date: Mon, 14 Nov 2005 11:50:55 -0500 [thread overview]
Message-ID: <20051114165055.22202.28533.stgit@dexter.citi.umich.edu> (raw)
In-Reply-To: <20051114165007.22202.69803.stgit@dexter.citi.umich.edu>
Generate a more precise error message when trying to rename a patch to the
same name. This is what we get currently:
[cel@dexter main]$ stg rename nfs_direct_wait nfs_direct_wait
Renaming patch "nfs_direct_wait" -> "nfs_direct_wait"...stg rename: Patch
"nfs_direct_wait" already exists
[cel@dexter main]$
Signed-off-by: Chuck Lever <cel@netapp.com>
---
stgit/stack.py | 3 +++
1 files changed, 3 insertions(+), 0 deletions(-)
diff --git a/stgit/stack.py b/stgit/stack.py
index 1ffeaee..0907b37 100644
--- a/stgit/stack.py
+++ b/stgit/stack.py
@@ -775,6 +775,9 @@ class Series:
applied = self.get_applied()
unapplied = self.get_unapplied()
+ if oldname == newname:
+ raise StackException, '"To" name and "from" name are the same'
+
if newname in applied or newname in unapplied:
raise StackException, 'Patch "%s" already exists' % newname
next prev parent reply other threads:[~2005-11-14 16:50 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-11-14 16:50 [PATCH 0/4] StGIT minor clean ups Chuck Lever
2005-11-14 16:50 ` Chuck Lever [this message]
2005-11-14 16:50 ` [PATCH 2/4] use "crt_series.get_branch()" instead of "git.get_head_file()" Chuck Lever
2005-11-14 16:50 ` [PATCH 3/4] Fix a typo in "stg pick" Chuck Lever
2005-11-14 16:51 ` [PATCH 4/4] Fix a typo in the "add" command's documentation Chuck Lever
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20051114165055.22202.28533.stgit@dexter.citi.umich.edu \
--to=cel@netapp.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox