git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Martin Atukunda <matlads@dsmagic.com>
To: git@vger.kernel.org
Subject: Re: [PATCH] Add .git/version
Date: Thu, 17 Nov 2005 22:08:48 +0300	[thread overview]
Message-ID: <20051117190848.GA5745@igloo.ds.co.ug> (raw)
In-Reply-To: <200511171741.23147.Josef.Weidendorfer@gmx.de>

On Thu, Nov 17, 2005 at 05:41:23PM +0100, Josef Weidendorfer wrote:
> On Thursday 17 November 2005 17:33, Andreas Ericsson wrote:
> > > Why? Ideally, the git commands first should check if they can handle the
> > > repository format. If they can not handle the version, they should bail
> > > out with an error [*]
> > > Now suppose we want to release Git 2 without change the repository
> > > format at all. Thus, even if Git 1 tool *would* work with repositories
> > > created by Git 2, they will fail in the version check!
> > > 
> > 
> > Not that I have an opinion on these changes, but Netscape 7 still 
> > handles HTTP 1.1. Just because we up the major-number for git doesn't 
> > mean we have to do the same for the repository format version.
> 
> Of course we do not want that.
> My comment was about this, as the proposed patch installed a
> .git/version file with the git version in it, which would lead to
> this strange result.
> 
I agree, I'll resubmit a patch to create a .git/version file that simply
says 1.

which specific git commands would most likely want to know about the
version of the repo format? I could look at them to see what needs to be
changed so that they don't corrupt a repo, or as Johannes said, the use
of this file would become handy only when an incompatible change is
made. In which case, init-db.c just creates it for now, as a simple safe
guard.

- Martin -

-- 
Due to a shortage of devoted followers, the production of great leaders has been discontinued.

  reply	other threads:[~2005-11-17 19:09 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-11-17 13:25 [PATCH] Add .git/version Martin Atukunda
2005-11-17 13:25 ` [PATCH 1/2] Build GIT_VERSION from VERSION, PATCHLEVEL, and SUBLEVEL variables Martin Atukunda
2005-11-17 13:25   ` [PATCH 2/2] Make init-db record the version in $GIT_DIR/version when creating repo Martin Atukunda
2005-11-17 13:39 ` [PATCH] Add .git/version Johannes Schindelin
2005-11-17 15:16   ` Martin Atukunda
2005-11-17 15:38     ` Johannes Schindelin
2005-11-17 16:04       ` Josef Weidendorfer
2005-11-17 15:44 ` Josef Weidendorfer
2005-11-17 16:33   ` Andreas Ericsson
2005-11-17 16:41     ` Josef Weidendorfer
2005-11-17 19:08       ` Martin Atukunda [this message]
2005-11-17 19:18         ` [PATCH] Add .git/version (Take 2) Martin Atukunda
2005-11-17 19:25   ` [PATCH] Add .git/version Junio C Hamano
2005-11-17 19:35     ` Linus Torvalds
2005-11-17 23:41       ` Johannes Schindelin
2005-11-18  0:49       ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20051117190848.GA5745@igloo.ds.co.ug \
    --to=matlads@dsmagic.com \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).