Git development
 help / color / mirror / Atom feed
From: Josef Weidendorfer <Josef.Weidendorfer@gmx.de>
To: git@vger.kernel.org, Alex Riesen <raa.lkml@gmail.com>
Cc: Junio C Hamano <junkio@cox.net>,
	Johannes Schindelin <Johannes.Schindelin@gmx.de>
Subject: Re: [PATCH] Make git-mv work in subdirectories, too
Date: Wed, 30 Nov 2005 15:50:10 +0100	[thread overview]
Message-ID: <200511301550.10644.Josef.Weidendorfer@gmx.de> (raw)
In-Reply-To: <20051129221024.GB3033@steel.home>

On Tuesday 29 November 2005 23:10, Alex Riesen wrote:

> It actually works in subdirs.
> 
> --- t/t4007-mv.sh

> test_expect_success \
>     'moving the file' \
>     'cd path0 && git-mv COPYING ../path1/COPYING'

Thanks for the test.
After moving to path1, you should check the other way, too:

  cd path0 && git-mv ../path1/COPYING COPYING

And this currenly does *not* work because git-mv is only aware
of the git-controlled files in the subdirectory.

We probably also should check that source and target are in the
same git repo.

Josef

      reply	other threads:[~2005-11-30 14:50 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-11-25 11:36 [PATCH] Make git-mv work in subdirectories, too Johannes Schindelin
2005-11-26  2:45 ` Junio C Hamano
2005-11-29 22:10   ` Alex Riesen
2005-11-30 14:50     ` Josef Weidendorfer [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200511301550.10644.Josef.Weidendorfer@gmx.de \
    --to=josef.weidendorfer@gmx.de \
    --cc=Johannes.Schindelin@gmx.de \
    --cc=git@vger.kernel.org \
    --cc=junkio@cox.net \
    --cc=raa.lkml@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox