From: Alex Riesen <raa.lkml@gmail.com>
To: Junio C Hamano <junkio@cox.net>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] Clean up compatibility definitions.
Date: Mon, 5 Dec 2005 22:50:59 +0100 [thread overview]
Message-ID: <20051205215059.GC4443@steel.home> (raw)
In-Reply-To: <7voe3vb8fh.fsf@assigned-by-dhcp.cox.net>
Junio C Hamano, Mon, Dec 05, 2005 21:22:42 +0100:
> This attempts to clean up the way various compatibility
> functions are defined and used.
...
> --- a/compat/mmap.c
> +++ b/compat/mmap.c
> @@ -2,7 +2,7 @@
> #include <stdlib.h>
> #include <unistd.h>
> #include <errno.h>
> -#include "../cache.h"
> +#include "../git-compat-util.h"
I still think that compat functions should stand alone.
Especially if it does not costs us much (or even less than that).
next prev parent reply other threads:[~2005-12-05 21:51 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-12-05 13:19 make gitfakemmap standalone to fix linking error in git.c Alex Riesen
2005-12-05 13:24 ` Alex Riesen
2005-12-05 14:11 ` Petr Baudis
2005-12-05 15:43 ` Alex Riesen
2005-12-05 17:40 ` Junio C Hamano
2005-12-05 20:22 ` [PATCH] Clean up compatibility definitions Junio C Hamano
2005-12-05 20:36 ` Johannes Schindelin
2005-12-05 20:51 ` Junio C Hamano
2005-12-05 21:39 ` Alex Riesen
2005-12-06 7:35 ` Alex Riesen
2005-12-06 7:58 ` Junio C Hamano
2005-12-05 21:50 ` Alex Riesen [this message]
2005-12-05 21:58 ` Junio C Hamano
2005-12-06 7:15 ` Alex Riesen
2005-12-06 7:31 ` Junio C Hamano
2005-12-06 8:07 ` Alex Riesen
2005-12-06 8:11 ` Junio C Hamano
2005-12-05 23:12 ` Petr Baudis
2005-12-06 3:17 ` Junio C Hamano
2005-12-06 9:53 ` Petr Baudis
2005-12-05 21:36 ` make gitfakemmap standalone to fix linking error in git.c Alex Riesen
2005-12-05 21:49 ` Junio C Hamano
2005-12-06 7:49 ` Alex Riesen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20051205215059.GC4443@steel.home \
--to=raa.lkml@gmail.com \
--cc=git@vger.kernel.org \
--cc=junkio@cox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).