From: Petr Baudis <pasky@suse.cz>
To: Junio C Hamano <junkio@cox.net>
Cc: git@vger.kernel.org, Alex Riesen <raa.lkml@gmail.com>
Subject: Re: [PATCH] Clean up compatibility definitions.
Date: Tue, 6 Dec 2005 10:53:14 +0100 [thread overview]
Message-ID: <20051206095314.GZ10680@pasky.or.cz> (raw)
In-Reply-To: <7vacfe9amx.fsf@assigned-by-dhcp.cox.net>
Dear diary, on Tue, Dec 06, 2005 at 04:17:58AM CET, I got a letter
where Junio C Hamano <junkio@cox.net> said that...
> Petr Baudis <pasky@suse.cz> writes:
>
> > Dear diary, on Mon, Dec 05, 2005 at 09:22:42PM CET, I got a letter
> > where Junio C Hamano <junkio@cox.net> said that...
> >> diff --git a/git-compat-util.h b/git-compat-util.h
> >> new file mode 100644
> >
> > What about compat/util.h or something? Nicer, shorter, and takes
> > advantage of this fancy hierarchical namespace "directories" invention.
> > ;-)
>
> While I would appreciate a better name, I am afraid that is not a
> particularly good one. It is not "compatibility utilities", but
> compat things and util things mixed together, so it does not
> belong to compat/ directory to begin with. die() and friends
> are not about compatibility at all.
Then perhaps the .h file should be split? At least the "compat-util"
name did not suggest combination to me, but specialization (not
"compatibility and utils" but "compatibility utils").
--
Petr "Pasky" Baudis
Stuff: http://pasky.or.cz/
VI has two modes: the one in which it beeps and the one in which
it doesn't.
next prev parent reply other threads:[~2005-12-06 9:53 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-12-05 13:19 make gitfakemmap standalone to fix linking error in git.c Alex Riesen
2005-12-05 13:24 ` Alex Riesen
2005-12-05 14:11 ` Petr Baudis
2005-12-05 15:43 ` Alex Riesen
2005-12-05 17:40 ` Junio C Hamano
2005-12-05 20:22 ` [PATCH] Clean up compatibility definitions Junio C Hamano
2005-12-05 20:36 ` Johannes Schindelin
2005-12-05 20:51 ` Junio C Hamano
2005-12-05 21:39 ` Alex Riesen
2005-12-06 7:35 ` Alex Riesen
2005-12-06 7:58 ` Junio C Hamano
2005-12-05 21:50 ` Alex Riesen
2005-12-05 21:58 ` Junio C Hamano
2005-12-06 7:15 ` Alex Riesen
2005-12-06 7:31 ` Junio C Hamano
2005-12-06 8:07 ` Alex Riesen
2005-12-06 8:11 ` Junio C Hamano
2005-12-05 23:12 ` Petr Baudis
2005-12-06 3:17 ` Junio C Hamano
2005-12-06 9:53 ` Petr Baudis [this message]
2005-12-05 21:36 ` make gitfakemmap standalone to fix linking error in git.c Alex Riesen
2005-12-05 21:49 ` Junio C Hamano
2005-12-06 7:49 ` Alex Riesen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20051206095314.GZ10680@pasky.or.cz \
--to=pasky@suse.cz \
--cc=git@vger.kernel.org \
--cc=junkio@cox.net \
--cc=raa.lkml@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).