From mboxrd@z Thu Jan 1 00:00:00 1970 From: Petr Baudis Subject: Re: [PATCH] Clean up compatibility definitions. Date: Tue, 6 Dec 2005 10:53:14 +0100 Message-ID: <20051206095314.GZ10680@pasky.or.cz> References: <81b0412b0512050519k5ed80035x9eb4907f569e0a4b@mail.gmail.com> <81b0412b0512050524w7b632651n93c836fda41a39d@mail.gmail.com> <7vfyp7cuii.fsf@assigned-by-dhcp.cox.net> <7voe3vb8fh.fsf@assigned-by-dhcp.cox.net> <20051205231203.GG22159@pasky.or.cz> <7vacfe9amx.fsf@assigned-by-dhcp.cox.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: git@vger.kernel.org, Alex Riesen X-From: git-owner@vger.kernel.org Tue Dec 06 10:54:41 2005 Return-path: Received: from vger.kernel.org ([209.132.176.167]) by ciao.gmane.org with esmtp (Exim 4.43) id 1EjZVa-0008OE-6u for gcvg-git@gmane.org; Tue, 06 Dec 2005 10:53:14 +0100 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S964939AbVLFJxA (ORCPT ); Tue, 6 Dec 2005 04:53:00 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S964937AbVLFJxA (ORCPT ); Tue, 6 Dec 2005 04:53:00 -0500 Received: from w241.dkm.cz ([62.24.88.241]:48799 "EHLO machine.or.cz") by vger.kernel.org with ESMTP id S964936AbVLFJw7 (ORCPT ); Tue, 6 Dec 2005 04:52:59 -0500 Received: (qmail 4334 invoked by uid 2001); 6 Dec 2005 10:53:14 +0100 To: Junio C Hamano Content-Disposition: inline In-Reply-To: <7vacfe9amx.fsf@assigned-by-dhcp.cox.net> X-message-flag: Outlook : A program to spread viri, but it can do mail too. User-Agent: Mutt/1.5.11 Sender: git-owner@vger.kernel.org Precedence: bulk X-Mailing-List: git@vger.kernel.org Archived-At: Dear diary, on Tue, Dec 06, 2005 at 04:17:58AM CET, I got a letter where Junio C Hamano said that... > Petr Baudis writes: > > > Dear diary, on Mon, Dec 05, 2005 at 09:22:42PM CET, I got a letter > > where Junio C Hamano said that... > >> diff --git a/git-compat-util.h b/git-compat-util.h > >> new file mode 100644 > > > > What about compat/util.h or something? Nicer, shorter, and takes > > advantage of this fancy hierarchical namespace "directories" invention. > > ;-) > > While I would appreciate a better name, I am afraid that is not a > particularly good one. It is not "compatibility utilities", but > compat things and util things mixed together, so it does not > belong to compat/ directory to begin with. die() and friends > are not about compatibility at all. Then perhaps the .h file should be split? At least the "compat-util" name did not suggest combination to me, but specialization (not "compatibility and utils" but "compatibility utils"). -- Petr "Pasky" Baudis Stuff: http://pasky.or.cz/ VI has two modes: the one in which it beeps and the one in which it doesn't.