From: Jonas Fonseca <fonseca@diku.dk>
To: Petr Baudis <pasky@ucw.cz>, git@vger.kernel.org
Subject: [PATCH] cg-object-id: comment the alternate id shortcut parsing
Date: Wed, 7 Dec 2005 22:39:43 +0100 [thread overview]
Message-ID: <20051207213943.GC25890@diku.dk> (raw)
Add comment about why Cogito's own 4 digit id shortcut parser is needed.
Signed-off-by: Jonas Fonseca <fonseca@diku.dk>
---
commit 3c14cded46e110396127fc5b5e65883eb5cd60b9
tree 593da711de14cfc3f8dc1fd5773990902568b42e
parent 36c0d9fae209ab7fa889333e8eebef22e7f0f55c
author Jonas Fonseca <fonseca@diku.dk> Wed, 07 Dec 2005 08:17:04 +0100
committer Jonas Fonseca <fonseca@antimatter.localdomain> Wed, 07 Dec 2005 08:17:04 +0100
cg-object-id | 4 +++-
1 files changed, 3 insertions(+), 1 deletions(-)
diff --git a/cg-object-id b/cg-object-id
index 56d9f91..ea04dca 100755
--- a/cg-object-id
+++ b/cg-object-id
@@ -52,7 +52,9 @@ normalize_id()
id="$revid"
valid=1
- # Short id's must be lower case and at least 4 digits.
+ # Short id's must be lower case and at least 4 digits. git-rev-parse(1)
+ # allows only down to 5 digits and we want to show the list of matched
+ # ids.
elif [[ "$id" == [0-9a-f][0-9a-f][0-9a-f][0-9a-f]* ]]; then
idpref=${id:0:2}
idpost=${id:2}
--
Jonas Fonseca
next reply other threads:[~2005-12-07 21:40 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-12-07 21:39 Jonas Fonseca [this message]
2005-12-07 22:05 ` [PATCH] cg-object-id: comment the alternate id shortcut parsing Petr Baudis
2005-12-07 22:14 ` Jonas Fonseca
2005-12-07 22:19 ` Jonas Fonseca
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20051207213943.GC25890@diku.dk \
--to=fonseca@diku.dk \
--cc=git@vger.kernel.org \
--cc=pasky@ucw.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).