From: Petr Baudis <pasky@suse.cz>
To: Pavel Roskin <proski@gnu.org>
Cc: git <git@vger.kernel.org>
Subject: Re: [PATCH] cg-clean: fix directory cleaning
Date: Tue, 13 Dec 2005 01:42:51 +0100 [thread overview]
Message-ID: <20051213004251.GA22159@pasky.or.cz> (raw)
In-Reply-To: <1134420860.4695.14.camel@dv>
Dear diary, on Mon, Dec 12, 2005 at 09:54:20PM CET, I got a letter
where Pavel Roskin <proski@gnu.org> said that...
> cg-clean is broken by commit 3cddede46dcd24bd7c36827ca564de23b2bb3517 -
> it removes all subdirectories when run in the top level directory.
>
> Although it's easy to make a one-line fix, I'd prefer a solution that
> makes cg-clean potentially safer. Since git-ls-files runs in
> subdirectories now, it's no longer needed to run anything in the top
> level directory and filter out the results. cg-clean now changes to
> $_git_relpath on startup and never uses $_git_relpath again.
>
> Signed-off-by: Pavel Roskin <proski@gnu.org>
Oops! Many thanks to both this and the testcase - I was just about to
write one, because those cg-clean bugs are really quite ugly. I'll
release 0.16.2 tomorrow if no other bug will be found.
--
Petr "Pasky" Baudis
Stuff: http://pasky.or.cz/
VI has two modes: the one in which it beeps and the one in which
it doesn't.
prev parent reply other threads:[~2005-12-13 0:42 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-12-12 20:54 [PATCH] cg-clean: fix directory cleaning Pavel Roskin
2005-12-13 0:42 ` Petr Baudis [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20051213004251.GA22159@pasky.or.cz \
--to=pasky@suse.cz \
--cc=git@vger.kernel.org \
--cc=proski@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).