git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* Re: git-name-rev off-by-one bug
@ 2005-12-04 21:34 Petr Baudis
  2005-12-08  6:34 ` as promised, docs: git for the confused linux
  0 siblings, 1 reply; 34+ messages in thread
From: Petr Baudis @ 2005-12-04 21:34 UTC (permalink / raw)
  To: Junio C Hamano; +Cc: linux, git

Dear diary, on Tue, Nov 29, 2005 at 07:46:20PM CET, I got a letter
where Junio C Hamano <junkio@cox.net> said that...
> Petr Baudis <pasky@suse.cz> writes:
> 
> >   (ii) Cogito will handle trees with some local modifications better -
> > basically any local modifications git-read-tree -m won't care about.
> > I didn't read the whole conversation, so to reiterate: git-read-tree
> > will complain when the index does not match the HEAD, but won't
> > complain about modified files in the working tree if the merge is not
> > going to touch them. Now, let's say you do this (output is visually
> > only roughly or not at all resembling what would real tools tell you):
> >
> > 	$ ls
> > 	a b c
> > 	$ echo 'somelocalhack' >>a
> > 	$ git merge "blah" HEAD remotehead
> > 	File-level merge of 'b' and 'c'...
> > 	Oops, 'b' contained local conflicts.
> > 	Automatic merge aborted, fix up by hand.
> > 	$ fixup b
> > 	$ git commit
> > 	Committed files 'a', 'b', 'c'.
> >
> > Oops. It grabbed your local hack and committed it along the merge.
> 
> Are you sure about this?
> 
> In the above sequence, after you touch a with 'somelocalhack',
> there is no 'git update-index a', until you say 'git commit'
> there, so I do not think that mixup is possible.
> 
> The "fixup b" step is actually two commands, so after merge
> command, you would do:
> 
>         $ edit b
> 	$ git update-index b ;# mark that you are dealt with it
> 	$ git commit ;# commits what is in index
> 
> After the above steps, "git diff" (that is working tree against
> index) still reports your local change to "a", which were _not_
> committed.

Yes. I actually tried it out, but I was confused by the file list in the
commit message (I'm used to seeing just committed files there) and I
didn't check the status of the 'a' file after the commit.

Sorry about the confusion.

-- 
				Petr "Pasky" Baudis
Stuff: http://pasky.or.cz/
VI has two modes: the one in which it beeps and the one in which
it doesn't.

^ permalink raw reply	[flat|nested] 34+ messages in thread

end of thread, other threads:[~2005-12-13 22:19 UTC | newest]

Thread overview: 34+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
     [not found] <7vbqzrcmgr.fsf@assigned-by-dhcp.cox.net>
2005-12-09  5:43 ` as promised, docs: git for the confused linux
2005-12-09  9:43   ` Petr Baudis
2005-12-09 14:01     ` linux
2005-12-09 16:49       ` Randy.Dunlap
2005-12-09 19:12       ` Junio C Hamano
2005-12-09 21:54         ` linux
2005-12-09 23:23           ` Junio C Hamano
2005-12-12 16:34             ` Linus Torvalds
2005-12-12 17:53               ` Timo Hirvonen
2005-12-12 18:18                 ` Linus Torvalds
2005-12-12 20:39                   ` Randal L. Schwartz
2005-12-13  3:58                     ` Joshua N Pritikin
2005-12-13  3:59                       ` Randal L. Schwartz
2005-12-13  5:19                         ` Junio C Hamano
2005-12-13  5:29                           ` Linus Torvalds
2005-12-13  7:18                             ` H. Peter Anvin
2005-12-13  8:01                           ` Junio C Hamano
2005-12-13 13:58                             ` Randal L. Schwartz
2005-12-13 21:16                               ` Tip of the day: archaeology Junio C Hamano
2005-12-13 21:54                                 ` Linus Torvalds
2005-12-13 22:19                                   ` Junio C Hamano
2005-12-12 17:54               ` as promised, docs: git for the confused Junio C Hamano
2005-12-13  0:22               ` [PATCH] Everyday: some examples Junio C Hamano
2005-12-09 21:33       ` as promised, docs: git for the confused Petr Baudis
2005-12-09  5:44 ` linux
2005-12-10  1:22   ` Junio C Hamano
2005-12-10  8:00   ` Junio C Hamano
2005-12-10 10:56     ` linux
2005-12-04 21:34 git-name-rev off-by-one bug Petr Baudis
2005-12-08  6:34 ` as promised, docs: git for the confused linux
2005-12-08 21:53   ` Junio C Hamano
2005-12-08 22:02     ` H. Peter Anvin
2005-12-09  0:47   ` Alan Chandler
2005-12-09  1:45     ` Petr Baudis
2005-12-09  1:19   ` Josef Weidendorfer

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).