From: Martin Atukunda <matlads@dsmagic.com>
To: git@vger.kernel.org
Subject: Re: [PATCH] [COGITO] make cg-tag use git-check-ref-format
Date: Tue, 13 Dec 2005 14:28:45 +0300 [thread overview]
Message-ID: <200512131428.45273.matlads@dsmagic.com> (raw)
In-Reply-To: <7vy82p9rnb.fsf@assigned-by-dhcp.cox.net>
On Tuesday 13 December 2005 14:13, Junio C Hamano wrote:
> Martin Atukunda <matlads@dsmagic.com> writes:
> > The egrep pattern used by cg-tag is too restrictive. While it will
> > prevent control characters from being specified as a tag name, it will
> > also reject nearly anything written in a non-English language, as noted
> > by -hpa ...
> > -(echo $name | egrep -qv '[^a-zA-Z0-9_.@!:-]') || \
> > +git-check-ref-format $name || \
> > die "name contains invalid characters"
>
> Perhaps you meant to say:
>
> git-check-ref-format "$name"
>
Yes. i've just finished preparing a new patch with this exact change. But your
patch is much better.
- Martin -
--
Due to a shortage of devoted followers, the production of great leaders has
been discontinued.
next prev parent reply other threads:[~2005-12-13 11:29 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-12-13 10:54 [PATCH] [COGITO] make cg-tag use git-check-ref-format Martin Atukunda
2005-12-13 11:13 ` Junio C Hamano
2005-12-13 11:28 ` Martin Atukunda [this message]
2005-12-13 17:00 ` Petr Baudis
2005-12-13 18:41 ` Junio C Hamano
2005-12-15 22:24 ` Alex Riesen
2005-12-15 23:38 ` Junio C Hamano
2005-12-16 2:17 ` Junio C Hamano
2005-12-16 9:17 ` Petr Baudis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200512131428.45273.matlads@dsmagic.com \
--to=matlads@dsmagic.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).