git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Petr Baudis <pasky@suse.cz>
To: Andreas Ericsson <ae@op5.se>
Cc: git@vger.kernel.org
Subject: Re: git cole give unexpected error message
Date: Wed, 14 Dec 2005 12:41:56 +0100	[thread overview]
Message-ID: <20051214114156.GG22159@pasky.or.cz> (raw)
In-Reply-To: <439FE7AD.6080602@op5.se>

Dear diary, on Wed, Dec 14, 2005 at 10:36:45AM CET, I got a letter
where Andreas Ericsson <ae@op5.se> said that...
> Petr Baudis wrote:
> >Dear diary, on Tue, Dec 13, 2005 at 10:28:20PM CET, I got a letter
> >where Sam Ravnborg <sam@ravnborg.org> said that...
> >
> >>cogito being a nice porcelain gives the git errormessage but manage to
> >>clean up when the clone fails.
> >>So also cogito would benefit from a more descriptive errormessage.
> >
> >
> >Well, git clone can fail for many reasons and I don't think the "no such
> >repository" one is completely overwhelming, so hinting that by Cogito
> >could be quite confusing (theme of the day: usability ;-)).
> >
> >The real solution would be proper error reporting by the git daemon.
> >
> 
> But that would open up for an information disclosure. If someone's 
> hacking on a patch, please make it configurable at least.

When it breaks at this stage, it's either some bad internal error (I
guess memory allocation error might do this), permission problem, or
repository not being found. We might then report a more generic error
message "Repository not found or access denied.".

-- 
				Petr "Pasky" Baudis
Stuff: http://pasky.or.cz/
VI has two modes: the one in which it beeps and the one in which
it doesn't.

  reply	other threads:[~2005-12-14 11:42 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-12-13 21:28 git cole give unexpected error message Sam Ravnborg
2005-12-13 22:28 ` Petr Baudis
2005-12-14  9:36   ` Andreas Ericsson
2005-12-14 11:41     ` Petr Baudis [this message]
2005-12-14 21:20   ` Sam Ravnborg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20051214114156.GG22159@pasky.or.cz \
    --to=pasky@suse.cz \
    --cc=ae@op5.se \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).