From: Sam Ravnborg <sam@ravnborg.org>
To: git@vger.kernel.org
Subject: Why do we need [PATCH]?
Date: Fri, 16 Dec 2005 22:01:45 +0100 [thread overview]
Message-ID: <20051216210145.GA25311@mars.ravnborg.org> (raw)
Hi git's.
I've just applied a patch to my git tree using git-applymbox.
It worked like a charm as it often do.
But then when I did a quick check with gitk it stuck me that
the subject was prefixed with [PATCH].
I am aware that the [PATCH] in subject tell me:
"patch is received from somewhere and applied by me to the .git tree".
This is in comparsion to patches received when I merge a git tree for
example.
But with common practice to use sign-off I wonder the value of this
patch marker.
When browsing the kernel shortlog I often focus on first word in subject
- cause this tells me what system/drivers is changed. But with the
[PATCH] marker I have to read some non-sense to see actual subject.
The information is redundant since metadata already tell me who is the
author and who committed the change.
So could we have it removed or if people continue to find it usefull
then at least hide it behind some option. Using the [PATCH] prefix is
not the natural thing to do with git.
I looked at the source and found the -k option, but adding [PATCH]
should not be default behaviour so this is not the correct solution.
Sam
next reply other threads:[~2005-12-16 21:00 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-12-16 21:01 Sam Ravnborg [this message]
2005-12-16 21:13 ` Why do we need [PATCH]? Dave Jones
2005-12-16 21:14 ` Brian Gerst
2005-12-16 21:27 ` Junio C Hamano
2005-12-16 21:42 ` Sam Ravnborg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20051216210145.GA25311@mars.ravnborg.org \
--to=sam@ravnborg.org \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).