From: Timo Hirvonen <tihirvon@gmail.com>
To: Junio C Hamano <junkio@cox.net>
Cc: git@vger.kernel.org
Subject: [PATCH] git-grep: convert from bash to sh
Date: Sun, 18 Dec 2005 15:26:39 +0200 [thread overview]
Message-ID: <20051218152639.5c14bc26.tihirvon@gmail.com> (raw)
sh does not support arrays so we have to use eval instead.
Signed-off-by: Timo Hirvonen <tihirvon@gmail.com>
---
git-grep.sh | 14 +++++++-------
1 files changed, 7 insertions(+), 7 deletions(-)
11c29a066288c5f05a67ff0d46e9ce17cd7a37da
diff --git a/git-grep.sh b/git-grep.sh
index 2ed8e95..2f0a297 100755
--- a/git-grep.sh
+++ b/git-grep.sh
@@ -8,21 +8,21 @@ SUBDIRECTORY_OK='Yes'
. git-sh-setup
pattern=
-flags=()
-git_flags=()
+flags=
+git_flags=
while : ; do
case "$1" in
--cached|--deleted|--others|--killed|\
--ignored|--exclude=*|\
--exclude-from=*|\--exclude-per-directory=*)
- git_flags=("${git_flags[@]}" "$1")
+ git_flags="$git_flags '$1'"
;;
-e)
pattern="$2"
shift
;;
-A|-B|-C|-D|-d|-f|-m)
- flags=("${flags[@]}" "$1" "$2")
+ flags="$flags '$1' '$2'"
shift
;;
--)
@@ -31,7 +31,7 @@ while : ; do
break
;;
-*)
- flags=("${flags[@]}" "$1")
+ flags="$flags '$1'"
;;
*)
if [ -z "$pattern" ]; then
@@ -46,5 +46,5 @@ done
[ "$pattern" ] || {
usage
}
-git-ls-files -z "${git_flags[@]}" "$@" |
- xargs -0 grep "${flags[@]}" -e "$pattern"
+eval git-ls-files -z "$git_flags" '"$@"' |
+ eval xargs -0 grep "$flags" -e '"$pattern"'
--
0.99.9.GIT
next reply other threads:[~2005-12-18 13:27 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-12-18 13:26 Timo Hirvonen [this message]
2005-12-18 14:56 ` [PATCH] git-grep: convert from bash to sh Petr Baudis
2005-12-18 19:37 ` Junio C Hamano
2005-12-18 19:57 ` Linus Torvalds
2005-12-18 20:18 ` Timo Hirvonen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20051218152639.5c14bc26.tihirvon@gmail.com \
--to=tihirvon@gmail.com \
--cc=git@vger.kernel.org \
--cc=junkio@cox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).