From: Timo Hirvonen <tihirvon@gmail.com>
To: Linus Torvalds <torvalds@osdl.org>
Cc: junkio@cox.net, git@vger.kernel.org
Subject: Re: [PATCH] git-grep: convert from bash to sh
Date: Sun, 18 Dec 2005 22:18:00 +0200 [thread overview]
Message-ID: <20051218221800.744e4565.tihirvon@gmail.com> (raw)
In-Reply-To: <Pine.LNX.4.64.0512181155360.4827@g5.osdl.org>
On Sun, 18 Dec 2005 11:57:26 -0800 (PST)
Linus Torvalds <torvalds@osdl.org> wrote:
> On Sun, 18 Dec 2005, Timo Hirvonen wrote:
> >
> > sh does not support arrays so we have to use eval instead.
>
> This seems horribly broken.
>
> If I'm not mistaken, this breaks
>
> git grep "it's a happy coincidence"
>
> badly. I didn't test, just looking at the patch.
Actually it works:
/usr/src/linux-2.6: git grep "it's a"
Documentation/Changes:debugfs. Obviously, it's a good idea to upgrade.
Documentation/CodingStyle:and NOT read it. Burn them, it's a great
symbolic gesture.
but it doesn't work with backslashes. Need to use \\
/usr/src/linux-2.6: git grep 'e.\\n"'
Documentation/DMA-mapping.txt: "mydev: No suitable DMA
available.\n");
Documentation/DMA-mapping.txt: "mydev: No suitable DMA
available.\n");
--
http://onion.dynserv.net/~timo/
prev parent reply other threads:[~2005-12-18 20:18 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-12-18 13:26 [PATCH] git-grep: convert from bash to sh Timo Hirvonen
2005-12-18 14:56 ` Petr Baudis
2005-12-18 19:37 ` Junio C Hamano
2005-12-18 19:57 ` Linus Torvalds
2005-12-18 20:18 ` Timo Hirvonen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20051218221800.744e4565.tihirvon@gmail.com \
--to=tihirvon@gmail.com \
--cc=git@vger.kernel.org \
--cc=junkio@cox.net \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).