git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Kyle McMartin <kyle@mcmartin.ca>
To: git@vger.kernel.org
Subject: git format-patch shell quoting bug
Date: Tue, 3 Jan 2006 23:55:19 -0500	[thread overview]
Message-ID: <20060104045519.GB29515@quicksilver.road.mcmartin.ca> (raw)

Hi,

There's apparently a quoting bug in git-format-patch. When I import
a patch with apply-mbox, for example

From: Carlos O'Donell <carlos@parisc-linux.org>

The author field is correctly set, including the "'" in Carlos' name.

So when I go to rebase my tree, or send out patches, I 
"git-format-patch origin" and get...

/usr/bin/git-format-patch: eval: line 200: unexpected EOF while looking for 
matching `''
/usr/bin/git-format-patch: eval: line 201: syntax error: unexpected end of file

Which produces a bogus output patch with a blank From and Date,

Subject: [PATCH] ...
From:
Date:

[...]

I believe this recently crept in, as I don't recall seeing it before.

Cheers,
	Kyle

             reply	other threads:[~2006-01-04  4:55 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-01-04  4:55 Kyle McMartin [this message]
2006-01-07  2:38 ` git format-patch shell quoting bug Junio C Hamano
2006-01-07 19:16   ` Kyle McMartin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060104045519.GB29515@quicksilver.road.mcmartin.ca \
    --to=kyle@mcmartin.ca \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).