* git format-patch shell quoting bug
@ 2006-01-04 4:55 Kyle McMartin
2006-01-07 2:38 ` Junio C Hamano
0 siblings, 1 reply; 3+ messages in thread
From: Kyle McMartin @ 2006-01-04 4:55 UTC (permalink / raw)
To: git
Hi,
There's apparently a quoting bug in git-format-patch. When I import
a patch with apply-mbox, for example
From: Carlos O'Donell <carlos@parisc-linux.org>
The author field is correctly set, including the "'" in Carlos' name.
So when I go to rebase my tree, or send out patches, I
"git-format-patch origin" and get...
/usr/bin/git-format-patch: eval: line 200: unexpected EOF while looking for
matching `''
/usr/bin/git-format-patch: eval: line 201: syntax error: unexpected end of file
Which produces a bogus output patch with a blank From and Date,
Subject: [PATCH] ...
From:
Date:
[...]
I believe this recently crept in, as I don't recall seeing it before.
Cheers,
Kyle
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: git format-patch shell quoting bug
2006-01-04 4:55 git format-patch shell quoting bug Kyle McMartin
@ 2006-01-07 2:38 ` Junio C Hamano
2006-01-07 19:16 ` Kyle McMartin
0 siblings, 1 reply; 3+ messages in thread
From: Junio C Hamano @ 2006-01-07 2:38 UTC (permalink / raw)
To: Kyle McMartin; +Cc: git
Kyle McMartin <kyle@mcmartin.ca> writes:
> There's apparently a quoting bug in git-format-patch. When I import
> a patch with apply-mbox, for example
>
> From: Carlos O'Donell <carlos@parisc-linux.org>
>
> The author field is correctly set, including the "'" in Carlos' name.
> ...
> I believe this recently crept in, as I don't recall seeing it before.
Thanks for spotting this.
There was a similar problem with "git-commit -c". I think I got
both of them right with commit aa66c7:
commit aa66c7ec77d474b737da607d6cb2d07f56628def
Author: Junio C Hamano <junkio@cox.net>
Date: Thu Jan 5 19:50:37 2006 -0800
format-patch/commit: Quote single quote in the author name properly.
Noticed by Kyle McMartin.
Signed-off-by: Junio C Hamano <junkio@cox.net>
The bug was present ever since format-patch started picking up
the original authorship information from the commits, done on
July 22nd last year, between v0.99.1 and v0.99.2.
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: git format-patch shell quoting bug
2006-01-07 2:38 ` Junio C Hamano
@ 2006-01-07 19:16 ` Kyle McMartin
0 siblings, 0 replies; 3+ messages in thread
From: Kyle McMartin @ 2006-01-07 19:16 UTC (permalink / raw)
To: Junio C Hamano; +Cc: git
On Fri, Jan 06, 2006 at 06:38:16PM -0800, Junio C Hamano wrote:
> commit aa66c7ec77d474b737da607d6cb2d07f56628def
> Author: Junio C Hamano <junkio@cox.net>
> Date: Thu Jan 5 19:50:37 2006 -0800
>
> format-patch/commit: Quote single quote in the author name properly.
>
> Noticed by Kyle McMartin.
>
> Signed-off-by: Junio C Hamano <junkio@cox.net>
>
> The bug was present ever since format-patch started picking up
> the original authorship information from the commits, done on
> July 22nd last year, between v0.99.1 and v0.99.2.
>
Awesome. Thanks very much for fixing this!
Cheers,
Kyle
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2006-01-07 19:17 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-01-04 4:55 git format-patch shell quoting bug Kyle McMartin
2006-01-07 2:38 ` Junio C Hamano
2006-01-07 19:16 ` Kyle McMartin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).