git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "David S. Miller" <davem@davemloft.net>
To: yoshfuji@linux-ipv6.org
Cc: junkio@cox.net, git@vger.kernel.org
Subject: Re: [ANNOUNCE] GIT 1.0.7
Date: Sat, 07 Jan 2006 00:29:04 -0800 (PST)	[thread overview]
Message-ID: <20060107.002904.87767885.davem@davemloft.net> (raw)
In-Reply-To: <20060107.021614.94523887.yoshfuji@linux-ipv6.org>

From: YOSHIFUJI Hideaki <yoshfuji@linux-ipv6.org>
Date: Sat, 07 Jan 2006 02:16:14 -0600 (CST)

> @@ -43,6 +43,7 @@ static void add_to_known_names(const cha
>  	struct commit_name *name = xmalloc(sizeof(struct commit_name) + len);
>  
>  	name->commit = commit;
> +	name->path = sizeof(*name);
>  	name->prio = prio; 
>  	memcpy(name->path, path, len);
>  	idx = names;

Why are you assigning an integer to a pointer? :-)
Probably you meant something like:

	struct commit_name *name = xmalloc(sizeof(struct commit_name) + len);

	...
	name->path = xmalloc(len);
	...

  reply	other threads:[~2006-01-07  8:29 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-01-07  7:01 [ANNOUNCE] GIT 1.0.7 Junio C Hamano
2006-01-07  8:16 ` YOSHIFUJI Hideaki / 吉藤英明
2006-01-07  8:29   ` David S. Miller [this message]
2006-01-07  8:33     ` YOSHIFUJI Hideaki / 吉藤英明
2006-01-07  8:43   ` Junio C Hamano
2006-01-07  9:56     ` Junio C Hamano
2006-01-07 12:12       ` Sergey Vlasov
2006-01-07 18:27         ` Junio C Hamano
2006-01-07 20:47       ` H. Peter Anvin
2006-01-07 21:12         ` Junio C Hamano
2006-01-07 21:30           ` H. Peter Anvin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060107.002904.87767885.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=git@vger.kernel.org \
    --cc=junkio@cox.net \
    --cc=yoshfuji@linux-ipv6.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).