From: Alex Riesen <raa.lkml@gmail.com>
To: Junio C Hamano <junkio@cox.net>
Cc: git@vger.kernel.org
Subject: Re: Use testlib to skip t3300-funny-names
Date: Sat, 7 Jan 2006 10:25:38 +0100 [thread overview]
Message-ID: <20060107092538.GA5536@steel.home> (raw)
In-Reply-To: <7vvewxq8xg.fsf@assigned-by-dhcp.cox.net>
Junio C Hamano, Fri, Jan 06, 2006 23:38:03 +0100:
> > The test cannot be run on cygwin anyway.
> > Corrected the error message to reflect the problem source.
>
> I'd rather see the test actually try to create a funny-named
> testfile and see if it managed to create it, so that it can be
> skipped on non DOS systems that mounted DOS filesystem.
>
> So instead I would do something like this:
>
> +test -f "$p1" && cmp "$p0" "$p1" || {
> + # since FAT/NTFS does not allow tabs in filenames, skip this test
> + say 'Your filesystem does not allow tabs in filenames, test skipped.'
> + test_done
> +}
Yes, that's better
prev parent reply other threads:[~2006-01-07 9:25 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-01-05 11:53 Use testlib to skip t3300-funny-names Alex Riesen
2006-01-06 22:38 ` Junio C Hamano
2006-01-07 9:25 ` Alex Riesen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060107092538.GA5536@steel.home \
--to=raa.lkml@gmail.com \
--cc=git@vger.kernel.org \
--cc=junkio@cox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).