From: Yann Dirson <ydirson@altern.org>
To: Junio C Hamano <junkio@cox.net>
Cc: git@vger.kernel.org
Subject: Re: [PATCH 1/7] Add a minimal test for git-cherry
Date: Sun, 8 Jan 2006 10:58:44 +0100 [thread overview]
Message-ID: <20060108095843.GD32585@nowhere.earth> (raw)
In-Reply-To: <7vy81r5ugx.fsf@assigned-by-dhcp.cox.net>
On Sat, Jan 07, 2006 at 06:22:54PM -0800, Junio C Hamano wrote:
> Yann Dirson <ydirson@altern.org> writes:
>
> > This test checks that git-cherry finds the expected number of patches
> > in two simple cases.
> >
> > Signed-off-by: Yann Dirson <ydirson@altern.org>
> >
> > +test_expect_success \
> > + 'cherry-pick one of the 2 patches, and check cherry recognized one and only one as new' \
> > + 'git-cherry-pick my-topic-branch^0 &&
> > + echo $(git-cherry master my-topic-branch) &&
> > + expr "$(echo $(git-cherry master my-topic-branch) )" : "+ [^ ]* - .*"
> > +'
>
> I wonder if "+ followed by -" order is stable here. If you make
> commits in the my-topic-branch fast enough, they would get the
> same timestamp and I suspect the order from rev-list would be
> left to chance.
We could maybe insert a sleep between the two commits ? Not that I
find it too appealing, however...
--
Yann Dirson <ydirson@altern.org> |
Debian-related: <dirson@debian.org> | Support Debian GNU/Linux:
| Freedom, Power, Stability, Gratis
http://ydirson.free.fr/ | Check <http://www.debian.org/>
prev parent reply other threads:[~2006-01-08 9:56 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-01-08 0:38 [PATCH 1/7] Add a minimal test for git-cherry Yann Dirson
2006-01-08 2:22 ` Junio C Hamano
2006-01-08 9:58 ` Yann Dirson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060108095843.GD32585@nowhere.earth \
--to=ydirson@altern.org \
--cc=git@vger.kernel.org \
--cc=junkio@cox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).