From: Eric Wong <normalperson@yhbt.net>
To: git list <git@vger.kernel.org>
Subject: [PATCH] rev-{list,parse}: allow -<n> as shorthand for --max-count=<n>
Date: Mon, 23 Jan 2006 23:29:46 -0800 [thread overview]
Message-ID: <20060124072946.GA9468@Muzzle> (raw)
Some versions of head(1) and tail(1) allow their line limits to be
parsed this way. I find --max-count to be a commonly used option,
and also similar in spirit to head/tail, so I decided to make life
easier on my worn out (and lazy :) fingers with this patch.
Signed-off-by: Eric Wong <normalperson@yhbt.net>
---
rev-list.c | 5 +++++
rev-parse.c | 4 ++++
2 files changed, 9 insertions(+), 0 deletions(-)
68df4b28986a4642119373e18a63751be0e26366
diff --git a/rev-list.c b/rev-list.c
index d060966..2bbd699 100644
--- a/rev-list.c
+++ b/rev-list.c
@@ -732,6 +732,11 @@ int main(int argc, const char **argv)
struct commit *commit;
unsigned char sha1[20];
+ /* accept, -<digit>, like some versions of head/tail */
+ if (*arg == '-' && isdigit(arg[1])) {
+ max_count = atoi(arg + 1);
+ continue;
+ }
if (!strncmp(arg, "--max-count=", 12)) {
max_count = atoi(arg + 12);
continue;
diff --git a/rev-parse.c b/rev-parse.c
index 0c951af..4dfc1a9 100644
--- a/rev-parse.c
+++ b/rev-parse.c
@@ -52,6 +52,10 @@ static int is_rev_argument(const char *a
};
const char **p = rev_args;
+ /* accept, -<digit>, like some versions of head/tail */
+ if (*arg == '-' && isdigit(arg[1]))
+ return 1;
+
for (;;) {
const char *str = *p++;
int len;
--
1.1.4.g68df
next reply other threads:[~2006-01-24 7:29 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-01-24 7:29 Eric Wong [this message]
2006-01-24 8:02 ` [PATCH] rev-{list,parse}: allow -<n> as shorthand for --max-count=<n> Junio C Hamano
2006-01-25 6:33 ` Eric Wong
2006-01-25 9:52 ` Junio C Hamano
2006-01-29 13:40 ` [PATCH] rev-{list,parse}: allow -n<n> " Eric Wong
2006-01-29 13:47 ` [PATCH] rev-{list,parse}: optionally allow -<n> " Eric Wong
2006-01-29 20:15 ` Junio C Hamano
2006-01-30 0:28 ` [PATCH] rev-{list,parse}: " Eric Wong
2006-01-29 20:15 ` [PATCH] rev-{list,parse}: allow -n<n> " Junio C Hamano
2006-01-30 0:25 ` Eric Wong
2006-01-30 0:26 ` Eric Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060124072946.GA9468@Muzzle \
--to=normalperson@yhbt.net \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).