From: Uwe Zeisberger <zeisberg@informatik.uni-freiburg.de>
To: Junio C Hamano <junkio@cox.net>
Cc: git@vger.kernel.org
Subject: Re: git describe fails without tags
Date: Thu, 26 Jan 2006 08:44:21 +0100 [thread overview]
Message-ID: <20060126074421.GA2941@informatik.uni-freiburg.de> (raw)
In-Reply-To: <7vek2wws61.fsf@assigned-by-dhcp.cox.net>
Hello Junio,
Junio C Hamano wrote:
> Uwe Zeisberger <zeisberg@informatik.uni-freiburg.de> writes:
>
> > I wonder if it would be sane to assume an implicit tag for the empty
> > repository, s.t. git describe results in
> >
> > <empty>-62ac6c16
> >
> > (whatever name is choosen for <empty>).
> >
> > Any opinions?
>
> [...] If the reason you are doing "describe" is to find out an usable
> abbreviated name, you could feed the first few hexdigits to "git
> rev-parse --verify", lengthening the prefix longer by one until it
> says you have a unique prefix [*1*].
Yes, I wrote a script that automatically build git and install it to
${HOME}/usr/stow/git-`git describe HEAD` and then stow(8)s it. Writing
a similar script for sparse cannot use git describe because there are no
tags ...
> In other words, not particularly interested, although it is
> trivial to implement, like this:
>
> diff --git a/describe.c b/describe.c
> index 4866510..aeaf0fb 100644
> --- a/describe.c
> +++ b/describe.c
> @@ -137,7 +137,7 @@ static void describe(char *arg, int last
> return;
> }
> }
> - die("cannot describe '%s'", sha1_to_hex(cmit->object.sha1));
> + printf("%s\n", find_unique_abbrev(cmit->object.sha1, abbrev));
> }
>
> int main(int argc, char **argv)
It's a pity your not particularly interested, I like that patch's idea.
git describe dies with an error here in a situation where there is the
possibility to do something sensible.
BTW, for the sake of consistency, I'd suggest
- die("cannot describe '%s'", sha1_to_hex(cmit->object.sha1));
+ printf("g%s\n", find_unique_abbrev(cmit->object.sha1, abbrev));
Best regards
Uwe
--
Uwe Zeisberger
http://www.google.com/search?q=1+year+divided+by+3+in+seconds
next prev parent reply other threads:[~2006-01-26 7:44 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-01-25 7:47 git describe fails without tags Uwe Zeisberger
2006-01-25 9:52 ` Junio C Hamano
2006-01-26 7:44 ` Uwe Zeisberger [this message]
2006-01-26 8:07 ` Junio C Hamano
2006-01-26 8:45 ` Uwe Zeisberger
2006-01-26 8:41 ` Uwe Zeisberger
2006-01-26 9:02 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060126074421.GA2941@informatik.uni-freiburg.de \
--to=zeisberg@informatik.uni-freiburg.de \
--cc=git@vger.kernel.org \
--cc=junkio@cox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox