From: Eric Wong <normalperson@yhbt.net>
To: Junio C Hamano <junkio@cox.net>
Cc: git list <git@vger.kernel.org>
Subject: [PATCH] rev-{list,parse}: allow -n<n> as shorthand for --max-count=<n>
Date: Sun, 29 Jan 2006 05:40:56 -0800 [thread overview]
Message-ID: <20060129134056.GA3428@Muzzle> (raw)
In-Reply-To: <20060125063325.GA7953@mail.yhbt.net>
Both -n<n> and -n <n> are supported. POSIX versions of head(1) and
tail(1) allow their line limits to be parsed this way. I find
--max-count to be a commonly used option, and also similar in spirit to
head/tail, so I decided to make life easier on my worn out (and lazy :)
fingers with this patch.
Signed-off-by: Eric Wong <normalperson@yhbt.net>
---
rev-list.c | 10 ++++++++++
rev-parse.c | 19 +++++++++++++++++++
2 files changed, 29 insertions(+), 0 deletions(-)
a598ce380cfcf01b27be92bca92a3c451d3b41e3
diff --git a/rev-list.c b/rev-list.c
index e00e6fc..33541cc 100644
--- a/rev-list.c
+++ b/rev-list.c
@@ -732,6 +732,16 @@ int main(int argc, const char **argv)
struct commit *commit;
unsigned char sha1[20];
+ if (!strcmp(arg, "-n")) {
+ if (++i >= argc)
+ die("-n requires an argument");
+ max_count = atoi(argv[i]);
+ continue;
+ }
+ if (!strncmp(arg,"-n",2)) {
+ max_count = atoi(arg + 2);
+ continue;
+ }
if (!strncmp(arg, "--max-count=", 12)) {
max_count = atoi(arg + 12);
continue;
diff --git a/rev-parse.c b/rev-parse.c
index 7abad35..3790463 100644
--- a/rev-parse.c
+++ b/rev-parse.c
@@ -21,6 +21,7 @@ static char *def = NULL;
static int show_type = NORMAL;
static int symbolic = 0;
static int output_sq = 0;
+static int next_arg_is_rev = 0;
static int revs_count = 0;
@@ -162,6 +163,24 @@ int main(int argc, char **argv)
show_file(arg);
continue;
}
+ if (next_arg_is_rev) {
+ if ((filter & DO_FLAGS) && (filter & DO_REVS))
+ show(arg);
+ next_arg_is_rev = 0;
+ continue;
+ }
+ if (!strcmp(arg,"-n")) {
+ next_arg_is_rev = 1;
+ if ((filter & DO_FLAGS) && (filter & DO_REVS))
+ show(arg);
+ continue;
+ }
+ if (!strncmp(arg,"-n",2)) {
+ if ((filter & DO_FLAGS) && (filter & DO_REVS))
+ show(arg);
+ continue;
+ }
+
if (*arg == '-') {
if (!strcmp(arg, "--")) {
as_is = 1;
--
1.1.4.g3b65
next prev parent reply other threads:[~2006-01-29 13:41 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-01-24 7:29 [PATCH] rev-{list,parse}: allow -<n> as shorthand for --max-count=<n> Eric Wong
2006-01-24 8:02 ` Junio C Hamano
2006-01-25 6:33 ` Eric Wong
2006-01-25 9:52 ` Junio C Hamano
2006-01-29 13:40 ` Eric Wong [this message]
2006-01-29 13:47 ` [PATCH] rev-{list,parse}: optionally " Eric Wong
2006-01-29 20:15 ` Junio C Hamano
2006-01-30 0:28 ` [PATCH] rev-{list,parse}: " Eric Wong
2006-01-29 20:15 ` [PATCH] rev-{list,parse}: allow -n<n> " Junio C Hamano
2006-01-30 0:25 ` Eric Wong
2006-01-30 0:26 ` Eric Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060129134056.GA3428@Muzzle \
--to=normalperson@yhbt.net \
--cc=git@vger.kernel.org \
--cc=junkio@cox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).