From: Nick Hengeveld <nickh@reactrix.com>
To: Junio C Hamano <junkio@cox.net>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] Fix HTTP request result processing after slot reuse
Date: Tue, 31 Jan 2006 17:50:47 -0800 [thread overview]
Message-ID: <20060201015047.GF3873@reactrix.com> (raw)
In-Reply-To: <7v64o0ulfu.fsf@assigned-by-dhcp.cox.net>
On Tue, Jan 31, 2006 at 01:39:01PM -0800, Junio C Hamano wrote:
> These static variables are probably correct, provided if
> fetch_index, fetch_indices and friends do not recurse into
> themselves, but it just gives me this funny feeling...
It's true that in the current implementation we either don't recurse
into these functions or we explicitly handle cases where we do such as
fetch_alternates. However, I've got no argument as to why the
structures should be static and can imagine it just causing problems
down the road if we were to eg. start downloading multiple packs
concurrently.
I'll follow up with a patch.
--
For a successful technology, reality must take precedence over public
relations, for nature cannot be fooled.
prev parent reply other threads:[~2006-02-01 1:51 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-01-31 19:06 [PATCH] Fix HTTP request result processing after slot reuse Nick Hengeveld
2006-01-31 21:39 ` Junio C Hamano
2006-02-01 1:50 ` Nick Hengeveld [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060201015047.GF3873@reactrix.com \
--to=nickh@reactrix.com \
--cc=git@vger.kernel.org \
--cc=junkio@cox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).