From: Nick Hengeveld <nickh@reactrix.com>
To: git@vger.kernel.org
Subject: [PATCH] Use local structs for HTTP slot callback data
Date: Tue, 31 Jan 2006 18:00:37 -0800 [thread overview]
Message-ID: <20060201020037.GG3873@reactrix.com> (raw)
There's no need for these structures to be static, and it could potentially
cause problems down the road.
Signed-off-by: Nick Hengeveld <nickh@reactrix.com>
---
http-fetch.c | 10 +++++-----
1 files changed, 5 insertions(+), 5 deletions(-)
6146f9e8be9d4bb49b7008af5b99853ee7c0afc1
diff --git a/http-fetch.c b/http-fetch.c
index 92326f9..97ce13c 100644
--- a/http-fetch.c
+++ b/http-fetch.c
@@ -375,7 +375,7 @@ static int fetch_index(struct alt_base *
FILE *indexfile;
struct active_request_slot *slot;
- static struct slot_results results;
+ struct slot_results results;
if (has_pack_index(sha1))
return 0;
@@ -555,7 +555,7 @@ static void fetch_alternates(char *base)
char *url;
char *data;
struct active_request_slot *slot;
- static struct alternates_request alt_req;
+ struct alternates_request alt_req;
/* If another request has already started fetching alternates,
wait for them to arrive and return to processing this request's
@@ -618,7 +618,7 @@ static int fetch_indices(struct alt_base
int i = 0;
struct active_request_slot *slot;
- static struct slot_results results;
+ struct slot_results results;
if (repo->got_indices)
return 0;
@@ -699,7 +699,7 @@ static int fetch_pack(struct alt_base *r
struct curl_slist *range_header = NULL;
struct active_request_slot *slot;
- static struct slot_results results;
+ struct slot_results results;
if (fetch_indices(repo))
return -1;
@@ -900,7 +900,7 @@ int fetch_ref(char *ref, unsigned char *
struct buffer buffer;
char *base = alt->base;
struct active_request_slot *slot;
- static struct slot_results results;
+ struct slot_results results;
buffer.size = 41;
buffer.posn = 0;
buffer.buffer = hex;
--
1.1.6.g1417-dirty
reply other threads:[~2006-02-01 2:00 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060201020037.GG3873@reactrix.com \
--to=nickh@reactrix.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).