From: Mark Wooding <mdw@distorted.org.uk>
To: git@vger.kernel.org
Subject: [PATCH 0/9] http-fetch fixes
Date: Wed, 01 Feb 2006 11:28:22 +0000 [thread overview]
Message-ID: <20060201112822.5042.41256.stgit@metalzone.distorted.org.uk> (raw)
This patch series fixes the git-http-fetch bug I reported in
`git-http-fetch failure/segfault -- alas no patch'. The preliminary
patch I was working on /did/ actually fix the bug I found, but uncovered
a bunch more, which I think I've finally got to the bottom of.
The series applies to commit 1506fc34f7585880aeeb12b5fdfe2de4800f9df5.
Particularly:
1. watch-slot -- my fix for the actual bug. Different from Nick
Hangeval's separate-status structure, it works by locking slots
that people still want answers from. I've turned the in_use slot
field into a bit mask and added a reference counter. I think you
can use Nick's patch instead if you prefer it.
2, 3. list-corruption, abort-object-request -- fix bugs uncovered by
watch-slot. See the patch emails for the details.
4, 5, 6, 7. multi-fdset, fix-rename-message, curl-verbose,
par-control-flow-tidy -- various other relatively trivial changes I
noticed while doing the main work above. fix-rename-message is
actually a bug, but if you think some other fix is better, that's
cool; the others are cosmetic things.
8, 9. sanity-check-active-slots, sanity-check-object-queue --
debugging code I threw in while I was trying to track down the main
bugs. I'm not going to cry if these aren't accepted (indeed, I
separated them out and put them at the end specifically!) but they
might prove useful to someone, so I thought I'd send 'em along
anyway.
-- [mdw]
next reply other threads:[~2006-02-01 11:44 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-02-01 11:28 Mark Wooding [this message]
2006-02-01 11:44 ` [PATCH 1/9] http-fetch: Mark slots as `watched' to stop them being reused Mark Wooding
2006-02-01 11:44 ` [PATCH 2/9] http-fetch: Fix object list corruption in fill_active_slots() Mark Wooding
2006-02-01 11:44 ` [PATCH 3/9] http-fetch: Abort requests for objects which arrived in packs Mark Wooding
2006-02-01 17:12 ` Nick Hengeveld
2006-02-01 17:23 ` Mark Wooding
2006-02-06 23:11 ` Nick Hengeveld
2006-02-01 11:44 ` [PATCH 4/9] http-fetch: Actually watch the file descriptors of interest Mark Wooding
2006-02-01 15:03 ` Nick Hengeveld
2006-02-01 11:44 ` [PATCH 5/9] http-fetch: Fix message reporting rename of object file Mark Wooding
2006-02-01 11:44 ` [PATCH 6/9] http: Turn on verbose Curl messages if GIT_CURL_VERBOSE set in environment Mark Wooding
2006-02-01 11:44 ` [PATCH 7/9] http-fetch: Tidy control flow in process_alternate_response Mark Wooding
2006-02-01 11:44 ` [PATCH 8/9] http: Paranoid sanity checking for active slots Mark Wooding
2006-02-01 11:44 ` [PATCH 9/9] http-fetch: Paranoid sanity checking for the object queue Mark Wooding
2006-02-01 15:30 ` [PATCH 0/9] http-fetch fixes Uwe Zeisberger
2006-02-01 15:47 ` Mark Wooding
2006-02-02 3:02 ` Junio C Hamano
2006-02-03 20:20 ` Mark Wooding
2006-02-03 20:42 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060201112822.5042.41256.stgit@metalzone.distorted.org.uk \
--to=mdw@distorted.org.uk \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).