From: Greg KH <greg@kroah.com>
To: Junio C Hamano <junkio@cox.net>
Cc: git@vger.kernel.org
Subject: Re: diffstat wierdness with 'git format-patch' output
Date: Mon, 13 Feb 2006 22:42:56 -0800 [thread overview]
Message-ID: <20060214064256.GA19667@kroah.com> (raw)
In-Reply-To: <20060214063420.GA11851@kroah.com>
On Mon, Feb 13, 2006 at 10:34:20PM -0800, Greg KH wrote:
> > I personally find it useful to see the trend of version of tools
> > people use on the public mailing list, and that was the primary
> > reason it is there.
>
> Why not just add a "X-Git-Version: 1.2.0" flag to the message instead?
And here's a patch that does just that.
-----------------
Subject: change git-format-patch to put the git version in the mail header
This is more like other tools that create mail messages, and fixes an
issue of the diffstat program thinking that an extra line was removed
from the patch.
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
diff --git a/git-format-patch.sh b/git-format-patch.sh
index e54c9e4..5f6a921 100755
--- a/git-format-patch.sh
+++ b/git-format-patch.sh
@@ -216,6 +216,7 @@ while (<FH>) {
print "From: $author_ident\n";
print "Date: $author_date\n";
+ print "X-Git-Version: @@GIT_VERSION@@\n";
}
next;
}
@@ -250,8 +251,6 @@ close FH or die "close $commsg pipe";
git-diff-tree -p $diff_opts "$commit" | git-apply --stat --summary
echo
git-diff-tree -p $diff_opts "$commit"
- echo "-- "
- echo "@@GIT_VERSION@@"
echo
}
next prev parent reply other threads:[~2006-02-14 6:42 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-02-14 5:54 diffstat wierdness with 'git format-patch' output Greg KH
2006-02-14 5:56 ` Greg KH
2006-02-14 6:09 ` Junio C Hamano
2006-02-14 6:34 ` Greg KH
2006-02-14 6:37 ` Junio C Hamano
2006-02-14 6:44 ` Greg KH
2006-02-14 6:42 ` Greg KH [this message]
2006-02-14 6:52 ` Greg KH
2006-02-14 7:10 ` Junio C Hamano
2006-02-18 0:34 ` Greg KH
2006-02-14 22:30 ` Fredrik Kuivinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060214064256.GA19667@kroah.com \
--to=greg@kroah.com \
--cc=git@vger.kernel.org \
--cc=junkio@cox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).