From: Shawn Pearce <spearce@spearce.org>
To: Krzysiek Pawlik <krzysiek.pawlik@people.pl>
Cc: Carl Worth <cworth@cworth.org>, git@vger.kernel.org
Subject: Re: [PATCH] Add new git-rm command with documentation
Date: Tue, 21 Feb 2006 17:14:46 -0500 [thread overview]
Message-ID: <20060221221446.GA20744@spearce.org> (raw)
In-Reply-To: <43FB8F31.9090302@people.pl>
How about supporting -- to break out of the option loop? The rest
of the script will support files named --help just fine but the
option parser will just spit out usage information.
[...]
> +while : ; do
> + case "$1" in
> + -n)
> + show_only=true
> + ;;
> + -v)
> + verbose=--verbose
> + ;;
> + -f)
> + remove_files=true
> + ;;
> + -*)
> + usage
> + ;;
> + *)
> + break
> + ;;
> + esac
> + shift
> +done
[...]
Also I don't think the -f option's whitespace matches the others...
--
Shawn.
next prev parent reply other threads:[~2006-02-21 22:15 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-02-21 21:47 [PATCH] Add new git-rm command with documentation Carl Worth
2006-02-21 22:07 ` Krzysiek Pawlik
2006-02-21 22:14 ` Shawn Pearce [this message]
2006-02-21 22:29 ` Krzysiek Pawlik
2006-02-21 22:32 ` Shawn Pearce
2006-02-21 22:36 ` Krzysiek Pawlik
2006-02-21 22:49 ` Carl Worth
2006-02-21 23:04 ` Carl Worth
2006-02-22 8:19 ` Junio C Hamano
2006-02-23 0:08 ` [PATCH] git-rm: Fix to properly handle files with spaces, tabs, newlines, etc Carl Worth
2006-02-23 0:37 ` Carl Worth
2006-02-23 1:07 ` Junio C Hamano
2006-02-24 13:23 ` Alex Riesen
2006-02-25 6:05 ` Junio C Hamano
2006-02-21 22:15 ` [PATCH] Add new git-rm command with documentation Johannes Schindelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060221221446.GA20744@spearce.org \
--to=spearce@spearce.org \
--cc=cworth@cworth.org \
--cc=git@vger.kernel.org \
--cc=krzysiek.pawlik@people.pl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).