From: Jan Harkes <jaharkes@cs.cmu.edu>
To: Junio C Hamano <junkio@cox.net>
Cc: git@vger.kernel.org
Subject: Re: How to not download objects more than needed?
Date: Tue, 21 Feb 2006 22:11:36 -0500 [thread overview]
Message-ID: <20060222031136.GN5000@delft.aura.cs.cmu.edu> (raw)
In-Reply-To: <7v3bicupgb.fsf@assigned-by-dhcp.cox.net>
On Tue, Feb 21, 2006 at 05:55:48PM -0800, Junio C Hamano wrote:
> Jan Harkes <jaharkes@cs.cmu.edu> writes:
> > On Tue, Feb 21, 2006 at 04:42:34PM -0800, Linus Torvalds wrote:
> >>
> >> git pull git://git.kernel.org/....
> >>
> >> and the automatic tag following kicks in, it will first have fetched the
> >> objects once, and then when it tries to fetch the tag objects, it will
> >> fetch the objects it already fetched _again_ (plus the tags), because it
> >> will do the same object pull, but the temporary branch (to be merged) will
> >> never have been written as a branch head.
> >
> > Isn't this easily avoided by fetching the tags first?
>
> I do not think so.
>
> Notice how the tag following code uses cat-file to determine if
> the main fetch likely has slurped the object they point at.
Neat, it only fetches tags that refer to things we already have. Hadn't
checked what the automatic tag fetcher was doing.
So either introduce temporary local refs that can be removed once the
tags have been fetched, or else fix it in fetch-pack with the following
change that might do the trick for this case as well. However that one
already got shot down because of possible consistency problems.
http://marc.theaimsgroup.com/?l=git&m=113030081014456&w=2
Jan
next prev parent reply other threads:[~2006-02-22 3:11 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-02-21 19:38 How to not download objects more than needed? Radoslaw Szkodzinski
[not found] ` <20060221161340.73a19228.seanlkml@sympatico.ca>
2006-02-21 21:13 ` sean
2006-02-22 0:42 ` Linus Torvalds
2006-02-22 1:13 ` Jan Harkes
2006-02-22 1:55 ` Junio C Hamano
2006-02-22 3:11 ` Jan Harkes [this message]
2006-02-22 3:22 ` Junio C Hamano
2006-02-22 21:12 ` [PATCH] git-fetch: follow tag only when tracking remote branch Junio C Hamano
2006-02-22 21:19 ` Andreas Ericsson
2006-02-21 21:32 ` How to not download objects more than needed? Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060222031136.GN5000@delft.aura.cs.cmu.edu \
--to=jaharkes@cs.cmu.edu \
--cc=git@vger.kernel.org \
--cc=junkio@cox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).