From: Jonas Fonseca <fonseca@diku.dk>
To: Junio C Hamano <junkio@cox.net>
Cc: Carl Worth <cworth@cworth.org>, git@vger.kernel.org
Subject: Re: [PATCH] Prevent git-upload-pack segfault if object cannot be found
Date: Thu, 23 Feb 2006 01:34:00 +0100 [thread overview]
Message-ID: <20060223003400.GA27800@diku.dk> (raw)
In-Reply-To: <7vr75vmcod.fsf@assigned-by-dhcp.cox.net>
Junio C Hamano <junkio@cox.net> wrote Wed, Feb 22, 2006:
> @@ -552,7 +563,9 @@ static void prepare_packed_git_one(char
> len = strlen(path);
> dir = opendir(path);
> if (!dir) {
> - fprintf(stderr, "unable to open object pack directory: %s: %s\n", path, strerror(errno));
> + if (errno != ENOENT)
> + error("unable to open object pack directory: %s: %s\n",
> + path, strerror(errno));
No need for the ending \n.
--
Jonas Fonseca
next prev parent reply other threads:[~2006-02-23 0:34 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-02-22 18:17 [PATCH] Prevent git-upload-pack segfault if object cannot be found Andrew Vasquez
2006-02-22 18:26 ` Junio C Hamano
2006-02-22 18:44 ` Carl Worth
2006-02-22 18:50 ` Junio C Hamano
2006-02-22 19:11 ` Junio C Hamano
2006-02-22 19:16 ` Carl Worth
2006-02-23 0:34 ` Jonas Fonseca [this message]
2006-02-23 1:48 ` [PATCH] Give no terminating LF to error() function Junio C Hamano
-- strict thread matches above, loose matches on Subject: below --
2006-02-18 0:14 [PATCH] Prevent git-upload-pack segfault if object cannot be found Carl Worth
2006-02-18 6:50 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060223003400.GA27800@diku.dk \
--to=fonseca@diku.dk \
--cc=cworth@cworth.org \
--cc=git@vger.kernel.org \
--cc=junkio@cox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).